Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

linkifiers: Add helper function to handle API errors. 

This commit adds a helper function named `handle_linkifier_api_error`
to `static/js/settings_linkifiers.js`. As the name suggests, this
function handles the error returned from the API, specifically
for operations on linkifiers (like adding linkifier).

This is a prep commit for `Add setting to edit linkifiers`.
Related issue: #10830.

The main motive to add this helper function is to avoid copying
substantial blocks of code, as it tends to result in someone later
fixing bugs in only one of the two places.
This commit is contained in:
akshatdalton 2021-03-25 14:05:19 +00:00 committed by Tim Abbott
parent 9f57961e5f
commit 5d35892bc9
1 changed files with 25 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
static/js/settings_linkifiers.js
View File

@ -40,6 +40,25 @@ function sort_url(a, b) {
return compare_values(a.url_format, b.url_format);
}
function handle_linkifier_api_error(xhr, pattern_status, format_status, linkifier_status) {
// The endpoint uses the Django ValidationError system for error
// handling, which returns somewhat complicated error
// dictionaries. This logic parses them.
const errors = JSON.parse(xhr.responseText).errors;
if (errors.pattern !== undefined) {
xhr.responseText = JSON.stringify({msg: errors.pattern});
ui_report.error($t_html({defaultMessage: "Failed"}), xhr, pattern_status);
}
if (errors.url_format_string !== undefined) {
xhr.responseText = JSON.stringify({msg: errors.url_format_string});
ui_report.error($t_html({defaultMessage: "Failed"}), xhr, format_status);
}
if (errors.__all__ !== undefined) {
xhr.responseText = JSON.stringify({msg: errors.__all__});
ui_report.error($t_html({defaultMessage: "Failed"}), xhr, linkifier_status);
}
}
export function populate_linkifiers(linkifiers_data) {
if (!meta.loaded) {
return;
@ -141,20 +160,13 @@ export function build_page() {
);
},
error(xhr) {
const errors = JSON.parse(xhr.responseText).errors;
add_linkifier_button.prop("disabled", false);
if (errors.pattern !== undefined) {
xhr.responseText = JSON.stringify({msg: errors.pattern});
ui_report.error($t_html({defaultMessage: "Failed"}), xhr, pattern_status);
}
if (errors.url_format_string !== undefined) {
xhr.responseText = JSON.stringify({msg: errors.url_format_string});
ui_report.error($t_html({defaultMessage: "Failed"}), xhr, format_status);
}
if (errors.__all__ !== undefined) {
xhr.responseText = JSON.stringify({msg: errors.__all__});
ui_report.error($t_html({defaultMessage: "Failed"}), xhr, linkifier_status);
}
handle_linkifier_api_error(
xhr,
pattern_status,
format_status,
linkifier_status,
);
},
});
});