Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

context_processors: Optimize calculation of social_backends. 

This avoids a bunch of duplicated calls to auth_enabled_helper for our
social auth backends, which added up because auth_enabled_helper can
take 100us to run.
This commit is contained in:
Tim Abbott 2019-03-17 15:20:36 -07:00
parent a9350caee2
commit 5d20138d72
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
zerver/context_processors.py
View File

@ -153,6 +153,7 @@ def zulip_default_context(request: HttpRequest) -> Dict[str, Any]:
# Add the keys for our standard authentication backends.
no_auth_enabled = True
social_backends = []
for auth_backend_name in AUTH_BACKEND_NAME_MAP:
name_lower = auth_backend_name.lower()
key = "%s_auth_enabled" % (name_lower,)
@ -161,9 +162,10 @@ def zulip_default_context(request: HttpRequest) -> Dict[str, Any]:
if is_enabled:
no_auth_enabled = False
social_backends = []
for backend in SOCIAL_AUTH_BACKENDS:
if not auth_enabled_helper([backend.auth_backend_name], realm):
# Now add the enabled social backends to the social_backends
# list used to generate buttons for login/register pages.
backend = AUTH_BACKEND_NAME_MAP[auth_backend_name]
if not is_enabled or backend not in SOCIAL_AUTH_BACKENDS:
continue
social_backends.append({
'name': backend.name,