Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

casper tests: Add an additional waitWhileVisible check. 

This fix at least one race and help prevent more race issues in the
casper tests for the organization administration pages.
This commit is contained in:
Tim Abbott 2020-01-15 17:49:21 -08:00
parent a82032a182
commit 5b30138a31
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
frontend_tests/casper_tests/10-admin.js
View File

@ -51,6 +51,7 @@ casper.then(function () {
casper.waitUntilVisible('#org-submit-notifications[data-status="saved"]', function () { casper.waitUntilVisible('#org-submit-notifications[data-status="saved"]', function () {
casper.test.assertSelectorHasText('#org-submit-notifications', 'Saved'); casper.test.assertSelectorHasText('#org-submit-notifications', 'Saved');
}); });
casper.waitWhileVisible('#org-submit-notifications');
}); });
casper.then(function () { casper.then(function () {
@ -63,6 +64,7 @@ casper.then(function () {
casper.waitUntilVisible('#org-submit-notifications[data-status="saved"]', function () { casper.waitUntilVisible('#org-submit-notifications[data-status="saved"]', function () {
casper.test.assertSelectorHasText('#org-submit-notifications', 'Saved'); casper.test.assertSelectorHasText('#org-submit-notifications', 'Saved');
}); });
casper.waitWhileVisible('#org-submit-notifications');
}); });
// Test changing signup notifications stream // Test changing signup notifications stream
@ -82,6 +84,7 @@ casper.then(function () {
casper.waitUntilVisible('#org-submit-notifications[data-status="saved"]', function () { casper.waitUntilVisible('#org-submit-notifications[data-status="saved"]', function () {
casper.test.assertSelectorHasText('#org-submit-notifications', 'Saved'); casper.test.assertSelectorHasText('#org-submit-notifications', 'Saved');
}); });
casper.waitWhileVisible('#org-submit-notifications');
}); });
casper.then(function () { casper.then(function () {
@ -94,6 +97,7 @@ casper.then(function () {
casper.waitUntilVisible('#org-submit-notifications[data-status="saved"]', function () { casper.waitUntilVisible('#org-submit-notifications[data-status="saved"]', function () {
casper.test.assertSelectorHasText('#org-submit-notifications', 'Saved'); casper.test.assertSelectorHasText('#org-submit-notifications', 'Saved');
}); });
casper.waitWhileVisible('#org-submit-notifications');
}); });
// Test permissions setting // Test permissions setting
@ -122,6 +126,7 @@ casper.then(function () {
casper.waitUntilVisible('#org-submit-other-permissions[data-status="saved"]', function () { casper.waitUntilVisible('#org-submit-other-permissions[data-status="saved"]', function () {
casper.test.assertSelectorHasText('#org-submit-other-permissions', 'Saved'); casper.test.assertSelectorHasText('#org-submit-other-permissions', 'Saved');
}); });
casper.waitWhileVisible('#org-submit-notifications');
}); });
// Test setting create streams policy to 'members and admins'. // Test setting create streams policy to 'members and admins'.
@ -140,6 +145,7 @@ casper.then(function () {
casper.waitUntilVisible('#org-submit-other-permissions[data-status="saved"]', function () { casper.waitUntilVisible('#org-submit-other-permissions[data-status="saved"]', function () {
casper.test.assertSelectorHasText('#org-submit-other-permissions', 'Saved'); casper.test.assertSelectorHasText('#org-submit-other-permissions', 'Saved');
}); });
casper.waitWhileVisible('#org-submit-notifications');
}); });
// Test setting create streams policy to 'full members'. // Test setting create streams policy to 'full members'.
@ -158,6 +164,7 @@ casper.then(function () {
casper.waitUntilVisible('#org-submit-other-permissions[data-status="saved"]', function () { casper.waitUntilVisible('#org-submit-other-permissions[data-status="saved"]', function () {
casper.test.assertSelectorHasText('#org-submit-other-permissions', 'Saved'); casper.test.assertSelectorHasText('#org-submit-other-permissions', 'Saved');
}); });
casper.waitWhileVisible('#org-submit-notifications');
}); });
// Test setting invite to streams policy to 'admins only'. // Test setting invite to streams policy to 'admins only'.
@ -176,6 +183,7 @@ casper.then(function () {
casper.waitUntilVisible('#org-submit-other-permissions[data-status="saved"]', function () { casper.waitUntilVisible('#org-submit-other-permissions[data-status="saved"]', function () {
casper.test.assertSelectorHasText('#org-submit-other-permissions', 'Saved'); casper.test.assertSelectorHasText('#org-submit-other-permissions', 'Saved');
}); });
casper.waitWhileVisible('#org-submit-notifications');
}); });
// Test setting invite to streams policy to 'members and admins'. // Test setting invite to streams policy to 'members and admins'.
@ -194,6 +202,7 @@ casper.then(function () {
casper.waitUntilVisible('#org-submit-other-permissions[data-status="saved"]', function () { casper.waitUntilVisible('#org-submit-other-permissions[data-status="saved"]', function () {
casper.test.assertSelectorHasText('#org-submit-other-permissions', 'Saved'); casper.test.assertSelectorHasText('#org-submit-other-permissions', 'Saved');
}); });
casper.waitWhileVisible('#org-submit-notifications');
}); });
// Test setting invite to streams policy to 'full members'. // Test setting invite to streams policy to 'full members'.
@ -212,6 +221,7 @@ casper.then(function () {
casper.waitUntilVisible('#org-submit-other-permissions[data-status="saved"]', function () { casper.waitUntilVisible('#org-submit-other-permissions[data-status="saved"]', function () {
casper.test.assertSelectorHasText('#org-submit-other-permissions', 'Saved'); casper.test.assertSelectorHasText('#org-submit-other-permissions', 'Saved');
}); });
casper.waitWhileVisible('#org-submit-notifications');
}); });
// Test setting new user threshold to three days. // Test setting new user threshold to three days.
@ -231,6 +241,7 @@ casper.then(function () {
casper.test.assertSelectorHasText('#org-submit-other-permissions', 'Saved'); casper.test.assertSelectorHasText('#org-submit-other-permissions', 'Saved');
casper.test.assertNotVisible('#id_realm_waiting_period_threshold'); casper.test.assertNotVisible('#id_realm_waiting_period_threshold');
}); });
casper.waitWhileVisible('#org-submit-notifications');
}); });
// Test setting new user threshold to N days. // Test setting new user threshold to N days.
@ -250,6 +261,7 @@ casper.then(function () {
casper.test.assertSelectorHasText('#org-submit-other-permissions', 'Saved'); casper.test.assertSelectorHasText('#org-submit-other-permissions', 'Saved');
casper.test.assertVisible('#id_realm_waiting_period_threshold'); casper.test.assertVisible('#id_realm_waiting_period_threshold');
}); });
casper.waitWhileVisible('#org-submit-notifications');
}); });
casper.then(function () { casper.then(function () {