Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

templates.js: Remove unused "plural" helper. 

This helper was added in eac6463031 and
used by the "message.handlebars" file. This is no current call for
this helper in the codebase, hence it is removed to improve coverage.

This commit also marks template.js to have 100% test coverage.
This commit is contained in:
YashRE42 2021-03-21 12:44:51 +00:00 committed by Tim Abbott
parent 4988f60a0f
commit 5b0db2e7ed
2 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
static/js/templates.js
View File

@ -14,8 +14,6 @@ import * as util from "./util";
// Furthermore, waiting for DOM ready would introduce race conditions with // Furthermore, waiting for DOM ready would introduce race conditions with
// other DOM-ready callbacks that attempt to render templates. // other DOM-ready callbacks that attempt to render templates.
Handlebars.registerHelper("plural", (condition, one, other) => (condition === 1 ? one : other));
Handlebars.registerHelper({ Handlebars.registerHelper({
eq(a, b) { eq(a, b) {
return a === b; return a === b;

1
tools/test-js-with-node
View File

@ -144,7 +144,6 @@ EXEMPT_FILES = {
"static/js/submessage.js", "static/js/submessage.js",
"static/js/subs.js", "static/js/subs.js",
"static/js/message_view_header.js", "static/js/message_view_header.js",
"static/js/templates.js",
"static/js/timerender.js", "static/js/timerender.js",
"static/js/todo_widget.js", "static/js/todo_widget.js",
"static/js/topic_list.js", "static/js/topic_list.js",