Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

buddy_list: Fix TypeScript noUncheckedIndexedAccess errors. 

Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg 2024-05-30 10:07:58 -07:00
parent 6cd8c9bb8c
commit 5a4b0420d1
1 changed files with 10 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
web/src/buddy_list.ts
View File

@ -46,7 +46,11 @@ function total_subscriber_count(
const pm_ids_list = [...pm_ids_set]; const pm_ids_list = [...pm_ids_set];
// Plus one for the "me" user, who isn't in the recipients list (except // Plus one for the "me" user, who isn't in the recipients list (except
// for when it's a private message conversation with only "me" in it). // for when it's a private message conversation with only "me" in it).
if (pm_ids_list.length === 1 && people.is_my_user_id(pm_ids_list[0])) { if (
pm_ids_list.length === 1 &&
pm_ids_list[0] !== undefined &&
people.is_my_user_id(pm_ids_list[0])
) {
return 1; return 1;
} }
return pm_ids_list.length + 1; return pm_ids_list.length + 1;
@ -610,22 +614,16 @@ export class BuddyList extends BuddyListConf {
find_position(opts: {user_id: number; user_id_list: number[]}): number { find_position(opts: {user_id: number; user_id_list: number[]}): number {
const user_id = opts.user_id; const user_id = opts.user_id;
let i;
const user_id_list = opts.user_id_list; const user_id_list = opts.user_id_list;
const current_sub = narrow_state.stream_sub(); const current_sub = narrow_state.stream_sub();
const pm_ids_set = narrow_state.pm_ids_set(); const pm_ids_set = narrow_state.pm_ids_set();
for (i = 0; i < user_id_list.length; i += 1) { const i = user_id_list.findIndex(
const list_user_id = user_id_list[i]; (list_user_id) =>
this.compare_function(user_id, list_user_id, current_sub, pm_ids_set) < 0,
if (this.compare_function(user_id, list_user_id, current_sub, pm_ids_set) < 0) { );
return i; return i === -1 ? user_id_list.length : i;
}
}
return user_id_list.length;
} }
force_render(opts: {pos: number}): void { force_render(opts: {pos: number}): void {