Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

scheduled_messages: Fix broken node test. 

This test just used the current hour, and thus would always fail at
24:00 UTC.
This commit is contained in:
Tim Abbott 2023-05-10 17:06:05 -07:00
parent e10997b0e6
commit 59daf54ec9
1 changed files with 13 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
web/tests/scheduled_messages.test.js
View File

@ -104,13 +104,6 @@ function get_expected_send_opts(day, expecteds) {
return modal_opts; return modal_opts;
} }
function get_minutes_to_hour(minutes) {
const date = new Date();
date.setMinutes(minutes);
date.setSeconds(0);
return date;
}
run_test("scheduled_modal_opts", () => { run_test("scheduled_modal_opts", () => {
// Sunday thru Saturday // Sunday thru Saturday
const days = [ const days = [
@ -168,6 +161,19 @@ run_test("missing_or_expired_timestamps", () => {
}); });
run_test("should_update_send_later_options", () => { run_test("should_update_send_later_options", () => {
// We should rerender at midnight
const start_of_the_day = new Date();
start_of_the_day.setHours(0, 0);
assert.ok(scheduled_messages.should_update_send_later_options(start_of_the_day));
function get_minutes_to_hour(minutes) {
const date = new Date();
date.setHours(4);
date.setMinutes(minutes);
date.setSeconds(0);
return date;
}
// We should rerender if it is 5 minutes before the hour // We should rerender if it is 5 minutes before the hour
for (let minute = 0; minute < 60; minute += 1) { for (let minute = 0; minute < 60; minute += 1) {
const current_time = get_minutes_to_hour(minute); const current_time = get_minutes_to_hour(minute);
@ -179,9 +185,4 @@ run_test("should_update_send_later_options", () => {
assert.ok(!scheduled_messages.should_update_send_later_options(current_time)); assert.ok(!scheduled_messages.should_update_send_later_options(current_time));
} }
} }
// We should rerender at midnight
const start_of_the_day = new Date();
start_of_the_day.setHours(0, 0);
assert.ok(scheduled_messages.should_update_send_later_options(start_of_the_day));
}); });