mirror of https://github.com/zulip/zulip.git
errbit: Strengthen types using WildValue.
This commit is contained in:
parent
66fd6b1e55
commit
5833c05fa6
|
@ -1,10 +1,9 @@
|
|||
from typing import Any, Dict
|
||||
|
||||
from django.http import HttpRequest, HttpResponse
|
||||
|
||||
from zerver.decorator import webhook_view
|
||||
from zerver.lib.request import REQ, has_request_variables
|
||||
from zerver.lib.response import json_success
|
||||
from zerver.lib.validator import WildValue, check_string, to_wild_value
|
||||
from zerver.lib.webhooks.common import check_send_webhook_message
|
||||
from zerver.models import UserProfile
|
||||
|
||||
|
@ -17,7 +16,7 @@ ERRBIT_MESSAGE_TEMPLATE = '[{error_class}]({error_url}): "{error_message}" occur
|
|||
def api_errbit_webhook(
|
||||
request: HttpRequest,
|
||||
user_profile: UserProfile,
|
||||
payload: Dict[str, Any] = REQ(argument_type="body"),
|
||||
payload: WildValue = REQ(argument_type="body", converter=to_wild_value),
|
||||
) -> HttpResponse:
|
||||
subject = get_subject(payload)
|
||||
body = get_body(payload)
|
||||
|
@ -25,15 +24,16 @@ def api_errbit_webhook(
|
|||
return json_success(request)
|
||||
|
||||
|
||||
def get_subject(payload: Dict[str, Any]) -> str:
|
||||
project = payload["problem"]["app_name"] + " / " + payload["problem"]["environment"]
|
||||
def get_subject(payload: WildValue) -> str:
|
||||
project = payload["problem"]["app_name"].tame(check_string)
|
||||
project += " / " + payload["problem"]["environment"].tame(check_string)
|
||||
return ERRBIT_TOPIC_TEMPLATE.format(project_name=project)
|
||||
|
||||
|
||||
def get_body(payload: Dict[str, Any]) -> str:
|
||||
def get_body(payload: WildValue) -> str:
|
||||
data = {
|
||||
"error_url": payload["problem"]["url"],
|
||||
"error_class": payload["problem"]["error_class"],
|
||||
"error_message": payload["problem"]["message"],
|
||||
"error_url": payload["problem"]["url"].tame(check_string),
|
||||
"error_class": payload["problem"]["error_class"].tame(check_string),
|
||||
"error_message": payload["problem"]["message"].tame(check_string),
|
||||
}
|
||||
return ERRBIT_MESSAGE_TEMPLATE.format(**data)
|
||||
|
|
Loading…
Reference in New Issue