Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

lint: Tighten placeholder lint rule to exclude links. 

Fixes #8420.
This commit is contained in:
Joshua Pan 2018-03-01 22:37:41 -08:00 committed by Tim Abbott
parent 5ccd3aa71b
commit 5777582013
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
tools/linter_lib/custom_check.py
View File

@ -534,18 +534,15 @@ def build_custom_checkers(by_lang):
'description': "The S in Terms of Service is capitalized"}, 'description': "The S in Terms of Service is capitalized"},
]) + comma_whitespace_rule ]) + comma_whitespace_rule
html_rules = whitespace_rules + prose_style_rules + [ html_rules = whitespace_rules + prose_style_rules + [
{'pattern': 'placeholder="[^{]', {'pattern': 'placeholder="[^{](?:(?!\.com).)+$',
'description': "`placeholder` value should be translatable.", 'description': "`placeholder` value should be translatable.",
'exclude_line': [('templates/zerver/register.html', 'placeholder="acme"'), 'exclude_line': [('templates/zerver/register.html', 'placeholder="acme"'),
('templates/zerver/register.html', 'placeholder="Acme or Aκμή"'), ('templates/zerver/register.html', 'placeholder="Acme or Aκμή"'),
('static/templates/settings/realm-domains-modal.handlebars',
'<td><input type="text" class="new-realm-domain" placeholder="acme.com" /></td>'),
("static/templates/user-groups-admin.handlebars", ("static/templates/user-groups-admin.handlebars",
'<input type="text" name="name" id="user_group_name" maxlength="100" placeholder="marketing" />')], '<input type="text" name="name" id="user_group_name" maxlength="100" placeholder="marketing" />')],
'exclude': set(["static/templates/settings/emoji-settings-admin.handlebars", 'exclude': set(["static/templates/settings/emoji-settings-admin.handlebars",
"static/templates/settings/realm-filter-settings-admin.handlebars", "static/templates/settings/realm-filter-settings-admin.handlebars",
"static/templates/settings/bot-settings.handlebars", "static/templates/settings/bot-settings.handlebars"]),
"templates/zerver/email_log.html"]),
'good_lines': ['<input class="stream-list-filter" type="text" placeholder="{{ _(\'Search streams\') }}" />'], 'good_lines': ['<input class="stream-list-filter" type="text" placeholder="{{ _(\'Search streams\') }}" />'],
'bad_lines': ['<input placeholder="foo">']}, 'bad_lines': ['<input placeholder="foo">']},
{'pattern': "placeholder='[^{]", {'pattern': "placeholder='[^{]",