Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

message send: Don't create user data list with inline `for`. 

This will make the code more readable, and will allow creating local
variables within the loop for reuse.
This commit is contained in:
Abhijeet Prasad Bodas 2021-06-10 19:51:09 +05:30 committed by Tim Abbott
parent 5a642cea11
commit 56f6656d8b
1 changed files with 12 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
zerver/lib/actions.py
View File

@ -1972,18 +1972,19 @@ def do_send_messages(
else:
user_list = list(user_ids)
users = [
dict(
id=user_id,
flags=user_flags.get(user_id, []),
online_push_enabled=(user_id in send_request.online_push_user_ids),
stream_push_notify=(user_id in send_request.stream_push_user_ids),
stream_email_notify=(user_id in send_request.stream_email_user_ids),
wildcard_mention_notify=(user_id in send_request.wildcard_mention_user_ids),
sender_is_muted=(user_id in send_request.muted_sender_user_ids),
users: List[Dict[str, Union[int, List[str], bool]]] = []
for user_id in user_list:
users.append(
dict(
id=user_id,
flags=user_flags.get(user_id, []),
online_push_enabled=(user_id in send_request.online_push_user_ids),
stream_push_notify=(user_id in send_request.stream_push_user_ids),
stream_email_notify=(user_id in send_request.stream_email_user_ids),
wildcard_mention_notify=(user_id in send_request.wildcard_mention_user_ids),
sender_is_muted=(user_id in send_request.muted_sender_user_ids),
)
)
for user_id in user_list
]
if send_request.message.is_stream_message():
# Note: This is where authorization for single-stream