Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

typeahead: Remove naturalSearch option. 

This was only relevant for search, which doesn't need
it anymore now that it's moved to pills.
This commit is contained in:
evykassirer 2024-01-17 15:20:00 -08:00 committed by Tim Abbott
parent 991c8451cd
commit 55ddf170a5
1 changed files with 0 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
web/src/bootstrap_typeahead.ts
View File

@ -252,7 +252,6 @@ export class Typeahead<ItemType extends string | object> {
closeInputFieldOnHide: (() => void) | undefined;
helpOnEmptyStrings: boolean;
tabIsEnter: boolean;
naturalSearch: boolean;
stopAdvance: boolean;
advanceKeyCodes: number[];
non_tippy_parent_element: string | undefined;
@ -301,7 +300,6 @@ export class Typeahead<ItemType extends string | object> {
this.closeInputFieldOnHide = options.closeInputFieldOnHide;
this.tabIsEnter = options.tabIsEnter ?? true;
this.helpOnEmptyStrings = options.helpOnEmptyStrings ?? false;
this.naturalSearch = options.naturalSearch ?? false;
this.non_tippy_parent_element = options.non_tippy_parent_element;
this.values = new WeakMap();
this.requireHighlight = options.requireHighlight ?? true;
@ -309,9 +307,6 @@ export class Typeahead<ItemType extends string | object> {
this.updateElementContent = options.updateElementContent ?? true;
this.hideAfterSelect = options.hideAfterSelect ?? (() => true);
// The naturalSearch option causes arrow keys to immediately
// update the search box with the underlying values from the
// search suggestions.
this.listen();
}
@ -536,10 +531,6 @@ export class Typeahead<ItemType extends string | object> {
}
$next.addClass("active");
if (this.naturalSearch) {
this.set_value();
}
}
prev(): void {
@ -558,10 +549,6 @@ export class Typeahead<ItemType extends string | object> {
}
$prev.addClass("active");
if (this.naturalSearch) {
this.set_value();
}
}
listen(): void {
@ -827,7 +814,6 @@ type TypeaheadOptions<ItemType> = {
header_html?: () => string | false;
helpOnEmptyStrings?: boolean;
matcher?: (item: ItemType, query: string) => boolean;
naturalSearch?: boolean;
on_escape?: () => void;
openInputFieldOnKeyUp?: () => void;
option_label?: (matching_items: ItemType[], item: ItemType) => string | false;