Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

coverage: bring test_classes.py to 100% coverage.

This commit is contained in:
Tim Abbott 2017-03-05 00:01:49 -08:00
parent e3cfb256dd
commit 546fb9199d
2 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
tools/test-backend
View File

@ -54,6 +54,7 @@ target_fully_covered = {path for target in [
'zerver/lib/notifications.py', 'zerver/lib/notifications.py',
'zerver/lib/push_notifications.py', 'zerver/lib/push_notifications.py',
'zerver/lib/request.py', 'zerver/lib/request.py',
'zerver/lib/test_classes.py',
'zerver/lib/upload.py', 'zerver/lib/upload.py',
'zerver/lib/validator.py', 'zerver/lib/validator.py',
'zerver/models.py', 'zerver/models.py',

10
zerver/lib/test_classes.py
View File

@ -79,7 +79,7 @@ class UploadSerializeMixin(SerializeMixin):
def setUpClass(cls, *args, **kwargs): def setUpClass(cls, *args, **kwargs):
# type: (*Any, **Any) -> None # type: (*Any, **Any) -> None
if not os.path.exists(cls.lockfile): if not os.path.exists(cls.lockfile):
with open(cls.lockfile, 'w'): with open(cls.lockfile, 'w'): # nocoverage - rare locking case
pass pass
super(UploadSerializeMixin, cls).setUpClass(*args, **kwargs) super(UploadSerializeMixin, cls).setUpClass(*args, **kwargs)
@ -246,7 +246,7 @@ class ZulipTestCase(TestCase):
return re.search(settings.EXTERNAL_HOST + path_pattern, return re.search(settings.EXTERNAL_HOST + path_pattern,
message.body).groups()[0] message.body).groups()[0]
else: else:
raise ValueError("Couldn't find a confirmation email.") raise AssertionError("Couldn't find a confirmation email.")
def get_api_key(self, email): def get_api_key(self, email):
# type: (Text) -> Text # type: (Text) -> Text
@ -359,10 +359,6 @@ class ZulipTestCase(TestCase):
# type: (HttpResponse, Text, int) -> None # type: (HttpResponse, Text, int) -> None
self.assertIn(msg_substring, self.get_json_error(result, status_code=status_code)) self.assertIn(msg_substring, self.get_json_error(result, status_code=status_code))
def assert_equals_response(self, string, response):
# type: (Text, HttpResponse) -> None
self.assertEqual(string, response.content.decode('utf-8'))
def assert_in_response(self, substring, response): def assert_in_response(self, substring, response):
# type: (Text, HttpResponse) -> None # type: (Text, HttpResponse) -> None
self.assertIn(substring, response.content.decode('utf-8')) self.assertIn(substring, response.content.decode('utf-8'))
@ -390,7 +386,7 @@ class ZulipTestCase(TestCase):
name=stream_name, name=stream_name,
invite_only=invite_only, invite_only=invite_only,
) )
except IntegrityError: except IntegrityError: # nocoverage -- this is for bugs in the tests
raise Exception(''' raise Exception('''
%s already exists %s already exists