Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

settings_notifications: Pass currentTarget instead using e.target. 

This function only uses `e` for its `target`, so it could instead be
passed the `HTMLInputElement` instead of the `JQuery.ChangeEvent`. The
caller is an event handler for the selector `"input, select"` and
`<input>` has no children, so there’s no difference here between
`.target` and `.currentTarget`.

This will be helpful for typescript, because `currentTarget` has
clearer typing.
This commit is contained in:
evykassirer 2024-10-01 22:45:27 -07:00 committed by Tim Abbott
parent b5352df782
commit 52b33868f1
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
web/src/settings_notifications.js
View File

@ -122,8 +122,8 @@ export function set_enable_marketing_emails_visibility() {
} }
} }
function stream_notification_setting_changed(e) { function stream_notification_setting_changed(target) {
const $row = $(e.target).closest(".stream-notifications-row"); const $row = $(target).closest(".stream-notifications-row");
const stream_id = Number.parseInt($row.attr("data-stream-id"), 10); const stream_id = Number.parseInt($row.attr("data-stream-id"), 10);
if (!stream_id) { if (!stream_id) {
blueslip.error("Cannot find stream id for target"); blueslip.error("Cannot find stream id for target");
@ -136,15 +136,15 @@ function stream_notification_setting_changed(e) {
return; return;
} }
const $status_element = $(e.target).closest(".subsection-parent").find(".alert-notification"); const $status_element = $(target).closest(".subsection-parent").find(".alert-notification");
const setting = e.target.name; const setting = target.name;
if (sub[setting] === null) { if (sub[setting] === null) {
sub[setting] = sub[setting] =
user_settings[settings_config.generalize_stream_notification_setting[setting]]; user_settings[settings_config.generalize_stream_notification_setting[setting]];
} }
stream_settings_api.set_stream_property( stream_settings_api.set_stream_property(
sub, sub,
{property: setting, value: e.target.checked}, {property: setting, value: target.checked},
$status_element, $status_element,
); );
} }
@ -220,7 +220,7 @@ export function set_up(settings_panel) {
e.stopPropagation(); e.stopPropagation();
const $input_elem = $(e.currentTarget); const $input_elem = $(e.currentTarget);
if ($input_elem.parents("#stream-specific-notify-table").length) { if ($input_elem.parents("#stream-specific-notify-table").length) {
stream_notification_setting_changed(e); stream_notification_setting_changed(e.currentTarget);
return; return;
} }
const setting_name = $input_elem.attr("name"); const setting_name = $input_elem.attr("name");