Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

custom linter rules test: Load rules in test setup.

This commit is contained in:
Robert Hönig 2017-09-13 15:31:00 +02:00 committed by Tim Abbott
parent 402d7fca50
commit 5294e10801
1 changed files with 32 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

56
tools/tests/test_linter_custom_check.py
View File

@ -4,36 +4,44 @@ from itertools import chain
from mock import patch, MagicMock from mock import patch, MagicMock
from unittest import TestCase from unittest import TestCase
from typing import Any, Dict, List
from tools.linter_lib.custom_check import build_custom_checkers from tools.linter_lib.custom_check import build_custom_checkers
ROOT_DIR = os.path.abspath(os.path.join(__file__, '..', '..', '..')) ROOT_DIR = os.path.abspath(os.path.join(__file__, '..', '..', '..'))
CHECK_MESSAGE = "Fix the corresponding rule in `tools/linter_lib/custom_check.py`." CHECK_MESSAGE = "Fix the corresponding rule in `tools/linter_lib/custom_check.py`."
@patch('tools.linter_lib.custom_check.custom_check_file', return_value=False)
class TestCustomRulesFormat(TestCase): class TestCustomRulesFormat(TestCase):
def test_paths_in_rules(self, mock_custom_check_file):
# type: (MagicMock) -> None def setUp(self):
# type: () -> None
self.all_rules = [] # type: List[Dict[str, Any]]
with patch('tools.linter_lib.custom_check.custom_check_file', return_value=False) as mock_custom_check_file:
by_lang = dict.fromkeys(['py', 'js', 'sh', 'css', 'handlebars', 'html', 'json', 'md', 'txt', 'text', 'yaml'],
['foo/bar.baz'])
check_custom_checks_py, check_custom_checks_nonpy = build_custom_checkers(by_lang)
check_custom_checks_py()
check_custom_checks_nonpy()
for call_args in mock_custom_check_file.call_args_list:
rule_set = call_args[0][2]
self.all_rules.extend(rule_set)
def test_paths_in_rules(self):
# type: () -> None
"""Verifies that the paths mentioned in linter rules actually exist""" """Verifies that the paths mentioned in linter rules actually exist"""
by_lang = dict.fromkeys(['py', 'js', 'sh', 'css', 'handlebars', 'html', 'json', 'md', 'txt', 'text', 'yaml'], for rule in self.all_rules:
['foo/bar.baz']) for path in rule.get('exclude', {}):
check_custom_checks_py, check_custom_checks_nonpy = build_custom_checkers(by_lang) abs_path = os.path.abspath(os.path.join(ROOT_DIR, path))
check_custom_checks_py() self.assertTrue(os.path.exists(abs_path),
check_custom_checks_nonpy() "'{}' is neither an existing file, nor a directory. {}".format(path, CHECK_MESSAGE))
for call_args in mock_custom_check_file.call_args_list:
rule_set = call_args[0][2]
for rule in rule_set:
for path in rule.get('exclude', {}):
abs_path = os.path.abspath(os.path.join(ROOT_DIR, path))
self.assertTrue(os.path.exists(abs_path),
"'{}' is neither an existing file, nor a directory. {}".format(path, CHECK_MESSAGE))
for line_tuple in rule.get('exclude_line', {}): for line_tuple in rule.get('exclude_line', {}):
path = line_tuple[0] path = line_tuple[0]
abs_path = os.path.abspath(os.path.join(ROOT_DIR, path)) abs_path = os.path.abspath(os.path.join(ROOT_DIR, path))
self.assertTrue(os.path.isfile(abs_path), self.assertTrue(os.path.isfile(abs_path),
"The file '{}' doesn't exist. {}".format(path, CHECK_MESSAGE)) "The file '{}' doesn't exist. {}".format(path, CHECK_MESSAGE))
for path in rule.get('include_only', {}): for path in rule.get('include_only', {}):
if not os.path.splitext(path)[1]: if not os.path.splitext(path)[1]:
self.assertTrue(path.endswith('/'), self.assertTrue(path.endswith('/'),
"The path '{}' should end with '/'. {}".format(path, CHECK_MESSAGE)) "The path '{}' should end with '/'. {}".format(path, CHECK_MESSAGE))