Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

markdown: Use common testcases for realmfilters in topics and messages. 

The actual bug in #11791 was caused by code reverted in
3ed85f4cd7, so technically #11791 is
already fixed.  However, it makes sense to add tests to ensure that it
doesn't regress in the future as part of closing out the issue.

Fixes #11791.
This commit is contained in:
Rohitt Vashishtha 2019-03-06 05:09:50 +00:00 committed by Tim Abbott
parent c05fb01cbf
commit 51986c27a5
1 changed files with 29 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

46
zerver/tests/test_bugdown.py
View File

@ -797,27 +797,39 @@ class BugdownTest(ZulipTestCase):
self.assertEqual(converted, '<p><a href="https://trac.zulip.net/ticket/ZUL-123" target="_blank" title="https://trac.zulip.net/ticket/ZUL-123">#ZUL-123</a> was fixed and code was deployed to production, also <a href="https://trac.zulip.net/ticket/zul-321" target="_blank" title="https://trac.zulip.net/ticket/zul-321">#zul-321</a> was deployed to staging</p>')
def was_converted(content: str) -> bool:
def assert_conversion(content: str, convert: bool=True) -> None:
converted = bugdown.convert(content, message_realm=realm, message=msg)
return 'trac.zulip.net' in converted
self.assertTrue(was_converted('Hello #123 World'))
self.assertTrue(not was_converted('Hello #123World'))
self.assertTrue(not was_converted('Hello#123 World'))
self.assertTrue(not was_converted('Hello#123World'))
converted_topic = bugdown.topic_links(realm.id, content)
if convert:
self.assertTrue('trac.zulip.net' in converted)
self.assertEqual(len(converted_topic), 1)
self.assertTrue('trac.zulip.net' in converted_topic[0])
else:
self.assertTrue('trac.zulip.net' not in converted)
self.assertEqual(len(converted_topic), 0)
assert_conversion('Hello #123 World')
assert_conversion('Hello #123World', False)
assert_conversion('Hello#123 World', False)
assert_conversion('Hello#123World', False)
# Ideally, these should be converted, but bugdown doesn't
# handle word boundary detection in languages that don't use
# whitespace for that correctly yet.
self.assertTrue(not was_converted('チケットは#123です'))
self.assertTrue(not was_converted('チケットは #123です'))
self.assertTrue(not was_converted('チケットは#123 です'))
self.assertTrue(was_converted('チケットは #123 です'))
self.assertTrue(was_converted('(#123)'))
self.assertTrue(was_converted('#123>'))
self.assertTrue(was_converted('"#123"'))
self.assertTrue(was_converted('#123@'))
self.assertTrue(not was_converted(')#123('))
self.assertTrue(not was_converted('##123'))
assert_conversion('チケットは#123です', False)
assert_conversion('チケットは #123です', False)
assert_conversion('チケットは#123 です', False)
assert_conversion('チケットは #123 です')
assert_conversion('(#123)')
assert_conversion('#123>')
assert_conversion('"#123"')
assert_conversion('#123@')
assert_conversion(')#123(', False)
assert_conversion('##123', False)
# test nested realm patterns should avoid double matching
RealmFilter(realm=realm, pattern=r'hello#(?P<id>[0-9]+)',
url_format_string=r'https://trac.zulip.net/hello/%(id)s').save()
converted_topic = bugdown.topic_links(realm.id, 'hello#123 #234')
self.assertEqual(converted_topic, ['https://trac.zulip.net/ticket/234', 'https://trac.zulip.net/hello/123'])
def test_maybe_update_markdown_engines(self) -> None:
realm = get_realm('zulip')