Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

stream_settings: Use button element for button used to change stream permission. 

We use button element instead of <a> element for the button used to change
stream permission. This change fixes the focus problem where the container
was focussed when closing the permission modal.

The problem here was because Micromodal focuses the element which was just
focused before opening the modal, on closing the modal. And in this case the
focused element before opening the modal was the "simplebar-content-wrapper"
element as <a> tah without href is not focusable element.

Related issue - #20223.
This commit is contained in:
Sahil Batra 2022-02-09 12:49:04 +05:30 committed by Tim Abbott
parent d5874dc840
commit 518024e826
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
static/templates/stream_settings/stream_settings.hbs
View File

@ -48,9 +48,9 @@
</h3>
<div class="stream_permission_change_info alert-notification"></div>
<div class="button-group">
<a class="change-stream-privacy button rounded small btn-warning" {{#unless can_change_stream_permissions}}style="display:none"{{/unless}} role="button">
<button class="change-stream-privacy button rounded small btn-warning" title="{{t 'Change stream permissions' }}" {{#unless can_change_stream_permissions}}style="display:none"{{/unless}}>
<i class="fa fa-pencil" aria-hidden="true"></i>
</a>
</button>
</div>
</div>
<div class="subscription-type">