Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

users: Tighten the type annotation of clean_profile_data. 

This change ensures that we can call the validate and update helper for
custom profile data later.

Signed-off-by: Zixuan James Li <p359101898@gmail.com>
This commit is contained in:
Zixuan James Li 2022-07-08 11:15:43 -04:00 committed by Tim Abbott
parent 00f2040ffa
commit 5116efa3de
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
zerver/views/users.py
View File

@ -48,7 +48,7 @@ from zerver.lib.rate_limiter import rate_limit_spectator_attachment_access_by_fi
from zerver.lib.request import REQ, has_request_variables from zerver.lib.request import REQ, has_request_variables
from zerver.lib.response import json_response_from_error, json_success from zerver.lib.response import json_response_from_error, json_success
from zerver.lib.streams import access_stream_by_id, access_stream_by_name, subscribed_to_stream from zerver.lib.streams import access_stream_by_id, access_stream_by_name, subscribed_to_stream
from zerver.lib.types import ProfileDataElementValue, Validator from zerver.lib.types import ProfileDataElementUpdateDict, ProfileDataElementValue, Validator
from zerver.lib.upload import upload_avatar_image from zerver.lib.upload import upload_avatar_image
from zerver.lib.url_encoding import append_url_query_string from zerver.lib.url_encoding import append_url_query_string
from zerver.lib.users import ( from zerver.lib.users import (
@ -211,9 +211,10 @@ def update_user_backend(
check_change_full_name(target, full_name, user_profile) check_change_full_name(target, full_name, user_profile)
if profile_data is not None: if profile_data is not None:
clean_profile_data = [] clean_profile_data: List[ProfileDataElementUpdateDict] = []
for entry in profile_data: for entry in profile_data:
assert isinstance(entry["id"], int) assert isinstance(entry["id"], int)
assert not isinstance(entry["value"], int)
if entry["value"] is None or not entry["value"]: if entry["value"] is None or not entry["value"]:
field_id = entry["id"] field_id = entry["id"]
check_remove_custom_profile_field_value(target, field_id) check_remove_custom_profile_field_value(target, field_id)