nagios: Don’t crash on missing cron file.

Signed-off-by: Anders Kaseorg <anders@zulip.com>

scripts/nagios/cron_file_helper.py

@@ -11,25 +11,31 @@ def nagios_from_file(results_file: str) -> Tuple[int, str]:
     This file is created by various nagios checking cron jobs such as
     check-rabbitmq-queues and check-rabbitmq-consumers"""
 
-    with open(results_file) as f:
-        data = f.read().strip()
-    pieces = data.split('|')
-
-    if not len(pieces) == 4:
+    try:
+        with open(results_file) as f:
+            data = f.read().strip()
+    except FileNotFoundError:
         state = 'UNKNOWN'
         ret = 3
-        data = "Results file malformed"
+        data = "Results file is missing"
     else:
-        timestamp = int(pieces[0])
+        pieces = data.split('|')
 
-        time_diff = time.time() - timestamp
-        if time_diff > 60 * 2:
-            ret = 3
+        if not len(pieces) == 4:
             state = 'UNKNOWN'
-            data = "Results file is stale"
+            ret = 3
+            data = "Results file malformed"
         else:
-            ret = int(pieces[1])
-            state = pieces[2]
-            data = pieces[3]
+            timestamp = int(pieces[0])
+
+            time_diff = time.time() - timestamp
+            if time_diff > 60 * 2:
+                ret = 3
+                state = 'UNKNOWN'
+                data = "Results file is stale"
+            else:
+                ret = int(pieces[1])
+                state = pieces[2]
+                data = pieces[3]
 
     return (ret, f"{state}: {data}")