Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

puppeteer: Fix the element becoming stale. 

As the right sidebar re-renders many times, often the
element puppeteer selected becomes stale, to avoid this
issue we are using javascript to click on the element.

This commit also ensures that the set user status modal
is completely open before we start clicking.
This commit is contained in:
Riken Shah 2021-07-30 04:54:08 +00:00 committed by Tim Abbott
parent 1f5fc12989
commit 4d3b10d84d
1 changed files with 18 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
frontend_tests/puppeteer_tests/user-status.ts
View File

@ -3,17 +3,29 @@ import type {Page} from "puppeteer";
import common from "../puppeteer_lib/common"; import common from "../puppeteer_lib/common";
async function open_set_user_status_modal(page: Page): Promise<void> { async function open_set_user_status_modal(page: Page): Promise<void> {
const buddy_list_me_item = "#user_presences .user_sidebar_entry:first-child"; const menu_icon_selector = ".user_sidebar_entry:first-child .user-list-sidebar-menu-icon";
await page.hover(buddy_list_me_item); // We are clicking on the menu icon with the help of `waitForFunction` because the list
const menu_icon_selector = buddy_list_me_item + " .user-list-sidebar-menu-icon"; // re-renders many times and can cause the element to become stale.
await page.waitForSelector(menu_icon_selector, {visible: true}); await page.waitForFunction(
await page.click(menu_icon_selector); (selector: string): boolean => {
const menu_icon = document.querySelector(selector);
if (menu_icon) {
(menu_icon as HTMLSpanElement).click();
return true;
}
return false;
},
{},
menu_icon_selector,
);
await page.waitForSelector(".user_popover", {visible: true}); await page.waitForSelector(".user_popover", {visible: true});
// We are using evaluate to click because it is very hard to detect if the user info popover has opened. // We are using evaluate to click because it is very hard to detect if the user info popover has opened.
await page.evaluate(() => await page.evaluate(() =>
(document.querySelector(".update_status_text") as HTMLAnchorElement)!.click(), (document.querySelector(".update_status_text") as HTMLAnchorElement)!.click(),
); );
await page.waitForSelector("#set_user_status_modal", {visible: true});
// Wait for the modal to completely open.
await page.waitForFunction(() => document.activeElement?.classList.contains("user_status"));
} }
async function test_user_status(page: Page): Promise<void> { async function test_user_status(page: Page): Promise<void> {