Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

mypy: Use Sequence in push notifications types. 

This is important for variance reasons.
This commit is contained in:
Tim Abbott 2021-07-24 11:08:12 -07:00
parent 6e26c8912e
commit 4aba6c9833
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
zerver/lib/push_notifications.py
View File

@ -130,7 +130,7 @@ APNS_MAX_RETRIES = 3
@statsd_increment("apple_push_notification")
def send_apple_push_notification(
user_id: int, devices: List[DeviceToken], payload_data: Dict[str, Any], remote: bool = False
user_id: int, devices: Sequence[DeviceToken], payload_data: Dict[str, Any], remote: bool = False
) -> None:
if not devices:
return
@ -294,7 +294,10 @@ def parse_gcm_options(options: Dict[str, Any], data: Dict[str, Any]) -> str:
@statsd_increment("android_push_notification")
def send_android_push_notification(
devices: List[DeviceToken], data: Dict[str, Any], options: Dict[str, Any], remote: bool = False
devices: Sequence[DeviceToken],
data: Dict[str, Any],
options: Dict[str, Any],
remote: bool = False,
) -> None:
"""
Send a GCM message to the given devices.