Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

user_card_popover: Remove redundant `userlist_placement` variable.

This commit is contained in:
Daniil Fadeev 2023-09-21 00:06:29 +06:00 committed by Tim Abbott
parent f609bc1f21
commit 472ef3d890
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
web/src/user_card_popover.js
View File

@ -48,8 +48,6 @@ let $current_user_card_popover_elem;
let current_user_sidebar_popover; let current_user_sidebar_popover;
let current_user_sidebar_user_id; let current_user_sidebar_user_id;
let userlist_placement = "right";
class PopoverMenu { class PopoverMenu {
constructor() { constructor() {
this.instance = null; this.instance = null;
@ -112,7 +110,6 @@ export function clear_for_testing() {
$current_message_user_card_popover_elem = undefined; $current_message_user_card_popover_elem = undefined;
$current_user_card_popover_elem = undefined; $current_user_card_popover_elem = undefined;
manage_menu.instance = undefined; manage_menu.instance = undefined;
userlist_placement = "right";
} }
function elem_to_user_id($elem) { function elem_to_user_id($elem) {
@ -544,7 +541,6 @@ function get_user_card_popover_for_message_items() {
function toggle_sidebar_user_card_popover($target) { function toggle_sidebar_user_card_popover($target) {
const user_id = elem_to_user_id($target.find("a")); const user_id = elem_to_user_id($target.find("a"));
const user = people.get_by_user_id(user_id); const user = people.get_by_user_id(user_id);
const popover_placement = userlist_placement === "left" ? "right" : "left";
// Hiding popovers may mutate current_user_sidebar_user_id. // Hiding popovers may mutate current_user_sidebar_user_id.
const previous_user_sidebar_id = current_user_sidebar_user_id; const previous_user_sidebar_id = current_user_sidebar_user_id;
@ -565,7 +561,7 @@ function toggle_sidebar_user_card_popover($target) {
false, false,
"compose_private_message", "compose_private_message",
"user_popover", "user_popover",
popover_placement, "left",
); );
current_user_sidebar_user_id = user.user_id; current_user_sidebar_user_id = user.user_id;