Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

tests: Remove `client` parameter if test can use default `User-Agent`. 

Removes `client` parameter from backend tests using the
`POST /messages` endpoint when the test can use the default
`User-Agent` as the client, which is set to `ZulipMobile` for API
requests and a browser user agent string for web app requests.
This commit is contained in:
Lauryn Menard 2022-02-22 18:45:46 +01:00 committed by Tim Abbott
parent bd0ddbe20e
commit 47056ef06f
8 changed files with 3 additions and 66 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
zerver/tests/test_decorators.py
View File

@ -1008,7 +1008,6 @@ class DeactivatedRealmTest(ZulipTestCase):
{
"type": "private",
"content": "Test message",
"client": "test suite",
"to": self.example_email("othello"),
},
)
@ -1026,7 +1025,6 @@ class DeactivatedRealmTest(ZulipTestCase):
{
"type": "private",
"content": "Test message",
"client": "test suite",
"to": self.example_email("othello"),
},
)
@ -1040,7 +1038,6 @@ class DeactivatedRealmTest(ZulipTestCase):
{
"type": "private",
"content": "Test message",
"client": "test suite",
"to": self.example_email("othello"),
},
)
@ -1161,7 +1158,6 @@ class InactiveUserTest(ZulipTestCase):
{
"type": "private",
"content": "Test message",
"client": "test suite",
"to": self.example_email("othello"),
},
)
@ -1177,7 +1173,6 @@ class InactiveUserTest(ZulipTestCase):
{
"type": "private",
"content": "Test message",
"client": "test suite",
"to": self.example_email("othello"),
},
)
@ -1189,7 +1184,6 @@ class InactiveUserTest(ZulipTestCase):
{
"type": "private",
"content": "Test message",
"client": "test suite",
"to": self.example_email("othello"),
},
)
@ -1291,7 +1285,6 @@ class TestIncomingWebhookBot(ZulipTestCase):
payload = dict(
type="private",
content="Test message",
client="test suite",
to=othello.email,
)

11
zerver/tests/test_email_mirror.py
View File

@ -850,7 +850,6 @@ class TestMissedMessageEmailMessages(ZulipTestCase):
{
"type": "private",
"content": "test_receive_missed_message_email_messages",
"client": "test suite",
"to": orjson.dumps([othello.id]).decode(),
},
)
@ -895,7 +894,6 @@ class TestMissedMessageEmailMessages(ZulipTestCase):
{
"type": "private",
"content": "test_receive_missed_message_email_messages",
"client": "test suite",
"to": orjson.dumps([cordelia.id, iago.id]).decode(),
},
)
@ -949,7 +947,6 @@ class TestMissedMessageEmailMessages(ZulipTestCase):
"type": "stream",
"topic": "test topic",
"content": "test_receive_missed_stream_message_email_messages",
"client": "test suite",
"to": "Denmark",
},
)
@ -989,7 +986,6 @@ class TestMissedMessageEmailMessages(ZulipTestCase):
"type": "stream",
"topic": "test topic",
"content": "test_receive_email_response_for_auth_failures",
"client": "test suite",
"to": "announce",
},
)
@ -1034,7 +1030,6 @@ class TestMissedMessageEmailMessages(ZulipTestCase):
"type": "stream",
"topic": "test topic",
"content": "test_receive_missed_stream_message_email_messages",
"client": "test suite",
"to": "Denmark",
},
)
@ -1080,7 +1075,6 @@ class TestMissedMessageEmailMessages(ZulipTestCase):
"type": "stream",
"topic": "test topic",
"content": "test_receive_missed_stream_message_email_messages",
"client": "test suite",
"to": "Denmark",
},
)
@ -1117,7 +1111,6 @@ class TestMissedMessageEmailMessages(ZulipTestCase):
"type": "stream",
"topic": "test topic",
"content": "test_receive_missed_stream_message_email_messages",
"client": "test suite",
"to": "Denmark",
},
)
@ -1155,7 +1148,6 @@ class TestMissedMessageEmailMessages(ZulipTestCase):
"type": "stream",
"topic": "test topic",
"content": "test_receive_missed_stream_message_email_messages",
"client": "test suite",
"to": "Denmark",
},
)
@ -1188,7 +1180,6 @@ class TestEmptyGatewaySetting(ZulipTestCase):
payload = dict(
type="private",
content="test_receive_missed_message_email_messages",
client="test suite",
to=orjson.dumps([cordelia.id, iago.id]).decode(),
)
result = self.client_post("/json/messages", payload)
@ -1358,7 +1349,6 @@ class TestEmailMirrorTornadoView(ZulipTestCase):
{
"type": "private",
"content": "test_receive_missed_message_email_messages",
"client": "test suite",
"to": orjson.dumps([cordelia.id, iago.id]).decode(),
},
)
@ -1624,7 +1614,6 @@ class TestEmailMirrorLogAndReport(ZulipTestCase):
{
"type": "private",
"content": "test_redact_email_message",
"client": "test suite",
"to": orjson.dumps([cordelia.email, iago.email]).decode(),
},
)

1
zerver/tests/test_email_notifications.py
View File

@ -380,7 +380,6 @@ class TestMissedMessages(ZulipTestCase):
{
"type": "private",
"content": "Test message",
"client": "website",
"to": hamlet.email,
},
)

1
zerver/tests/test_external.py
View File

@ -116,7 +116,6 @@ class RateLimitTests(ZulipTestCase):
{
"type": "stream",
"to": "Verona",
"client": "test suite",
"content": content,
"topic": "whatever",
},

1
zerver/tests/test_legacy_subject.py
View File

@ -8,7 +8,6 @@ class LegacySubjectTest(ZulipTestCase):
payload = dict(
type="stream",
to="Verona",
client="test suite",
content="Test message",
)

39
zerver/tests/test_message_send.py
View File

@ -91,7 +91,6 @@ class MessagePOSTTest(ZulipTestCase):
{
"type": "stream",
"to": "Verona",
"client": "test suite",
"content": "Test message",
"topic": "Test topic",
},
@ -109,7 +108,6 @@ class MessagePOSTTest(ZulipTestCase):
{
"type": "stream",
"to": "Verona",
"client": "test suite",
"content": "Test message",
"topic": "Test topic",
},
@ -128,7 +126,6 @@ class MessagePOSTTest(ZulipTestCase):
{
"type": "stream",
"to": orjson.dumps([99999]).decode(),
"client": "test suite",
"content": "Stream message by ID.",
"topic": "Test topic for stream ID message",
},
@ -155,7 +152,6 @@ class MessagePOSTTest(ZulipTestCase):
{
"type": "stream",
"to": orjson.dumps([stream.id]).decode(),
"client": "test suite",
"content": "Stream message by ID.",
"topic": "Test topic for stream ID message",
},
@ -458,7 +454,6 @@ class MessagePOSTTest(ZulipTestCase):
"/api/v1/messages",
{
"type": "stream",
"client": "test suite",
"content": "Test message no to",
"topic": "Test topic",
},
@ -480,7 +475,6 @@ class MessagePOSTTest(ZulipTestCase):
{
"type": "stream",
"to": "nonexistent_stream",
"client": "test suite",
"content": "Test message",
"topic": "Test topic",
},
@ -498,7 +492,6 @@ class MessagePOSTTest(ZulipTestCase):
{
"type": "stream",
"to": """&<"'><non-existent>""",
"client": "test suite",
"content": "Test message",
"topic": "Test topic",
},
@ -519,7 +512,6 @@ class MessagePOSTTest(ZulipTestCase):
{
"type": "private",
"content": "Test message",
"client": "test suite",
"to": othello.email,
},
)
@ -539,7 +531,6 @@ class MessagePOSTTest(ZulipTestCase):
{
"type": "private",
"content": "Test message",
"client": "test suite",
"to": user_profile.email,
},
)
@ -569,7 +560,6 @@ class MessagePOSTTest(ZulipTestCase):
{
"type": "private",
"content": "Test message",
"client": "test suite",
"to": orjson.dumps([self.example_user("othello").id]).decode(),
},
)
@ -589,7 +579,6 @@ class MessagePOSTTest(ZulipTestCase):
{
"type": "private",
"content": "Test message",
"client": "test suite",
"to": orjson.dumps(
[self.example_user("othello").id, self.example_user("cordelia").id]
).decode(),
@ -623,7 +612,6 @@ class MessagePOSTTest(ZulipTestCase):
{
"type": "private",
"content": "Test message",
"client": "test suite",
"to": orjson.dumps([hamlet.id, othello.id]).decode(),
},
)
@ -642,7 +630,6 @@ class MessagePOSTTest(ZulipTestCase):
{
"type": "private",
"content": "Test message",
"client": "test suite",
"to": "nonexistent",
},
)
@ -662,7 +649,6 @@ class MessagePOSTTest(ZulipTestCase):
{
"type": "private",
"content": "Test message",
"client": "test suite",
"to": orjson.dumps([othello.id]).decode(),
},
)
@ -673,7 +659,6 @@ class MessagePOSTTest(ZulipTestCase):
{
"type": "private",
"content": "Test message",
"client": "test suite",
"to": orjson.dumps([othello.id, cordelia.id]).decode(),
},
)
@ -690,7 +675,6 @@ class MessagePOSTTest(ZulipTestCase):
{
"type": "invalid type",
"content": "Test message",
"client": "test suite",
"to": othello.email,
},
)
@ -704,7 +688,7 @@ class MessagePOSTTest(ZulipTestCase):
othello = self.example_user("othello")
result = self.client_post(
"/json/messages",
{"type": "private", "content": " ", "client": "test suite", "to": othello.email},
{"type": "private", "content": " ", "to": othello.email},
)
self.assert_json_error(result, "Message must not be empty")
@ -718,7 +702,6 @@ class MessagePOSTTest(ZulipTestCase):
{
"type": "stream",
"to": "Verona",
"client": "test suite",
"content": "Test message",
"topic": "",
},
@ -732,7 +715,7 @@ class MessagePOSTTest(ZulipTestCase):
self.login("hamlet")
result = self.client_post(
"/json/messages",
{"type": "stream", "to": "Verona", "client": "test suite", "content": "Test message"},
{"type": "stream", "to": "Verona", "content": "Test message"},
)
self.assert_json_error(result, "Missing topic")
@ -747,7 +730,6 @@ class MessagePOSTTest(ZulipTestCase):
{
"type": "stream",
"to": "Verona",
"client": "test suite",
"topic": "Test\n\rTopic",
"content": "Test message",
},
@ -760,7 +742,6 @@ class MessagePOSTTest(ZulipTestCase):
{
"type": "stream",
"to": "Verona",
"client": "test suite",
"topic": "Test\uFFFETopic",
"content": "Test message",
},
@ -777,7 +758,6 @@ class MessagePOSTTest(ZulipTestCase):
{
"type": "invalid",
"to": "Verona",
"client": "test suite",
"content": "Test message",
"topic": "Test topic",
},
@ -791,7 +771,7 @@ class MessagePOSTTest(ZulipTestCase):
self.login("hamlet")
result = self.client_post(
"/json/messages",
{"type": "private", "content": "Test content", "client": "test suite", "to": ""},
{"type": "private", "content": "Test content", "to": ""},
)
self.assert_json_error(result, "Message must have recipients")
@ -912,7 +892,6 @@ class MessagePOSTTest(ZulipTestCase):
post_data = {
"type": "stream",
"to": "Verona",
"client": "test suite",
"content": " I like null bytes \x00 in my content",
"topic": "Test topic",
}
@ -927,7 +906,6 @@ class MessagePOSTTest(ZulipTestCase):
post_data = {
"type": "stream",
"to": "Verona",
"client": "test suite",
"content": " I like whitespace at the end! \n\n \n",
"topic": "Test topic",
}
@ -940,7 +918,6 @@ class MessagePOSTTest(ZulipTestCase):
post_data = {
"type": "stream",
"to": "Verona",
"client": "test suite",
"content": "\nAvoid the new line at the beginning of the message.",
"topic": "Test topic",
}
@ -963,7 +940,6 @@ class MessagePOSTTest(ZulipTestCase):
post_data = {
"type": "stream",
"to": "Verona",
"client": "test suite",
"content": long_message,
"topic": "Test topic",
}
@ -985,7 +961,6 @@ class MessagePOSTTest(ZulipTestCase):
post_data = {
"type": "stream",
"to": "Verona",
"client": "test suite",
"content": "test content",
"topic": long_topic,
}
@ -1002,7 +977,6 @@ class MessagePOSTTest(ZulipTestCase):
{
"type": "stream",
"to": "Verona",
"client": "test suite",
"content": "Test message",
"topic": "Test topic",
"forged": "true",
@ -1017,7 +991,6 @@ class MessagePOSTTest(ZulipTestCase):
{
"type": "stream",
"to": "Verona",
"client": "test suite",
"content": "Test message",
"topic": "Test topic",
"realm_str": "mit",
@ -1035,7 +1008,6 @@ class MessagePOSTTest(ZulipTestCase):
{
"type": "stream",
"to": "Verona",
"client": "test suite",
"content": "Test message",
"topic": "Test topic",
"realm_str": "non-existing",
@ -1051,7 +1023,6 @@ class MessagePOSTTest(ZulipTestCase):
{
"type": "stream",
"to": "Verona",
"client": "test suite",
"content": "Test message",
"topic": "Test topic",
"realm_str": zephyr_realm.string_id,
@ -1306,7 +1277,6 @@ class MessagePOSTTest(ZulipTestCase):
payload = dict(
type="stream",
to=stream_name,
client="test suite",
topic="whatever",
content="whatever",
)
@ -1333,7 +1303,6 @@ class MessagePOSTTest(ZulipTestCase):
{
"type": "stream",
"to": "notify_channel",
"client": "test suite",
"content": "Test message",
"topic": "Test topic",
},
@ -1355,7 +1324,6 @@ class MessagePOSTTest(ZulipTestCase):
payload = dict(
type="stream",
to=stream_name,
client="test suite",
topic="whatever",
content="whatever",
)
@ -1393,7 +1361,6 @@ class ScheduledMessageTest(ZulipTestCase):
payload = {
"type": msg_type,
"to": to,
"client": "test suite",
"content": msg,
"topic": topic_name,
"realm_str": realm_str,

1
zerver/tests/test_user_groups.py
View File

@ -302,7 +302,6 @@ class UserGroupAPITestCase(UserGroupTestCase):
payload = dict(
type="stream",
to=stream_name,
client="test suite",
topic="whatever",
content=content_with_group_mention,
)

8
zerver/tests/test_widgets.py
View File

@ -65,7 +65,6 @@ class WidgetContentTestCase(ZulipTestCase):
payload = dict(
type="stream",
to=stream_name,
client="test suite",
topic="whatever",
content="whatever",
)
@ -122,7 +121,6 @@ class WidgetContentTestCase(ZulipTestCase):
payload = dict(
type="stream",
to=stream_name,
client="test suite",
topic="whatever",
content=content,
widget_content=orjson.dumps(widget_content).decode(),
@ -153,7 +151,6 @@ class WidgetContentTestCase(ZulipTestCase):
payload = dict(
type="stream",
to=stream_name,
client="test suite",
topic="whatever",
content=content,
)
@ -182,7 +179,6 @@ class WidgetContentTestCase(ZulipTestCase):
payload = dict(
type="stream",
to=stream_name,
client="test suite",
topic="whatever",
content=content,
)
@ -234,7 +230,6 @@ class WidgetContentTestCase(ZulipTestCase):
payload = dict(
type="stream",
to=stream_name,
client="test suite",
topic="whatever",
content=content,
)
@ -263,7 +258,6 @@ class WidgetContentTestCase(ZulipTestCase):
payload = dict(
type="stream",
to=stream_name,
client="test suite",
topic="whatever",
content=content,
)
@ -322,7 +316,6 @@ class WidgetContentTestCase(ZulipTestCase):
payload = dict(
type="stream",
to=stream_name,
client="test suite",
topic="whatever",
content=content,
)
@ -380,7 +373,6 @@ class WidgetContentTestCase(ZulipTestCase):
payload = dict(
type="stream",
to=stream_name,
client="test suite",
topic="whatever",
content=content,
)