Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

typeahead: Remove default value for triage. 

"get_item"'s default value is not type-safe as we require its return
value to always be a "string". Note that since the mobile app does not
rely on this function directly, it is sufficient to only refactor the web
app for this transition.

Signed-off-by: Zixuan James Li <p359101898@gmail.com>
This commit is contained in:
Zixuan James Li 2022-12-28 15:28:52 +08:00 committed by Tim Abbott
parent ec58b6790d
commit 45fdfcd6d4
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
static/js/search_suggestion.js
View File

@ -112,7 +112,7 @@ function get_stream_suggestions(last, operators) {
streams = streams.filter((stream) => stream_matches_query(stream, query));
streams = typeahead_helper.sorter(query, streams);
streams = typeahead_helper.sorter(query, streams, (x) => x);
const regex = typeahead_helper.build_highlight_regex(query);
const highlight_query = typeahead_helper.highlight_with_escaping_and_regex;

2
static/js/typeahead_helper.js
View File

@ -287,7 +287,7 @@ function retain_unique_language_aliases(matches) {
}
export function sort_languages(matches, query) {
const results = typeahead.triage(query, matches);
const results = typeahead.triage(query, matches, (x) => x);
// Languages that start with the query
results.matches = results.matches.sort(compare_by_popularity);

2
static/shared/js/typeahead.js
View File

@ -91,7 +91,7 @@ export function get_emoji_matcher(query) {
};
}
export function triage(query, objs, get_item = (x) => x) {
export function triage(query, objs, get_item) {
/*
We split objs into four groups: