Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

settings: Add bootstrap CSS rules for select elements. 

This commit adds bootstrap CSS rules used for select
elements in settings page in settings.css.

This change is done so we can safely remove select CSS
rules from bootstrap.css as a part of our process to
remove bootstrap.

Due to this change, a couple of settings have lesser
margin at the bottom than before, but they look fine
with lesser margins and anyways had unnecessarily
larger margin before.

We also update the selector used to set width of
desktop-icon-count-display setting such that the
default of 220px is correctly overridden by the
specific CSS for this element.
This commit is contained in:
Sahil Batra 2022-12-25 15:55:38 +05:30 committed by Tim Abbott
parent a3a3f7796a
commit 45fcd9ee45
1 changed files with 21 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
static/styles/settings.css
View File

@ -373,6 +373,22 @@ td .button {
#id_realm_enable_spectator_access_label a { #id_realm_enable_spectator_access_label a {
color: hsl(0, 0%, 20%); color: hsl(0, 0%, 20%);
} }
select {
height: 30px;
width: 220px;
padding: 4px 6px;
color: hsl(0, 0%, 33%);
border-radius: 4px;
border: 1px solid hsl(0, 0%, 80%);
cursor: pointer;
background-color: hsl(0, 0%, 100%);
&:disabled {
cursor: not-allowed;
background-color: hsl(0, 0%, 93%);
}
}
} }
#admin-user-list, #admin-user-list,
@ -393,9 +409,10 @@ td .button {
.input-group { .input-group {
/* Class to use when the following input-group is related and should /* Class to use when the following input-group is related and should
appear just after this element. */ appear just after this element. Normally the margin is 20px, but
for related settings, we set it to 10px. */
&.thinner { &.thinner {
margin: 0; margin-bottom: 10px;
} }
label.checkbox + label { label.checkbox + label {
@ -1446,7 +1463,8 @@ $option_title_width: 180px;
} }
/* These have enough space for all the options in German. */ /* These have enough space for all the options in German. */
.setting_desktop_icon_count_display, #user_desktop_icon_count_display,
#realm_desktop_icon_count_display,
#id_realm_waiting_period_threshold, #id_realm_waiting_period_threshold,
#id_realm_create_public_stream_policy, #id_realm_create_public_stream_policy,
#id_realm_create_private_stream_policy, #id_realm_create_private_stream_policy,