provision: Clean up comments and unused variables.

This has some changes inspired by #8514.

tools/lib/provision.py

@@ -211,8 +211,6 @@ REPO_STOPWORDS_PATH = os.path.join(
     "zulip_english.stop",
 )
 
-LOUD = dict(_out=sys.stdout, _err=sys.stderr)
-
 user_id = os.getuid()
 
 def setup_shell_profile(shell_profile):
@@ -413,8 +411,8 @@ def main(options):
     # create linecoverage directory `var/node-coverage`
     os.makedirs(NODE_TEST_COVERAGE_DIR_PATH, exist_ok=True)
 
-    # `build_emoji` script requires `emoji-datasource` package which we install
-    # via npm and hence it should be executed after we are done installing npm
+    # The `build_emoji` script requires `emoji-datasource` package
+    # which we install via npm; thus this step is after installing npm
     # packages.
     if not os.path.isdir(EMOJI_CACHE_PATH):
         run(["sudo", "mkdir", EMOJI_CACHE_PATH])

tools/provision

@@ -14,8 +14,7 @@ FAIL='\033[91m'
 WARNING='\033[93m'
 ENDC='\033[0m'
 
-#Make the script independent of the location from where it is
-#executed
+# Make the script independent of the location from where it is executed
 PARENT_PATH=$( cd "$(dirname "${BASH_SOURCE[0]}")" ; pwd -P )
 cd "$PARENT_PATH"
 mkdir -p ../var/log