Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

refactor: Flatten code in subs.change_state().

This commit is contained in:
Steve Howell 2018-12-01 23:24:45 +00:00 committed by Tim Abbott
parent 84d0b541e3
commit 45227e84fc
1 changed files with 18 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
static/js/subs.js
View File

@ -612,29 +612,26 @@ exports.switch_to_stream_row = function (stream_id) {
}, 100);
};
exports.change_state = (function () {
exports.change_state = function (hash) {
if (hash.arguments.length === 0) {
return;
}
// TODO: flatten this code
var func = function (hash) {
// if there are any arguments the state should be modified.
if (hash.arguments.length > 0) {
// if in #streams/new form.
if (hash.arguments[0] === "new") {
exports.do_open_create_stream();
} else if (hash.arguments[0] === "all") {
maybe_select_tab("all-streams");
} else if (hash.arguments[0] === "subscribed") {
maybe_select_tab("subscribed");
// if the first argument is a valid number.
} else if (/\d+/.test(hash.arguments[0])) {
var stream_id = hash.arguments[0];
exports.switch_to_stream_row(stream_id);
}
}
};
var base = hash.arguments[0];
return func;
}());
// if in #streams/new form.
if (base === "new") {
exports.do_open_create_stream();
} else if (base === "all") {
maybe_select_tab("all-streams");
} else if (base === "subscribed") {
maybe_select_tab("subscribed");
// if the first argument is a valid number.
} else if (/\d+/.test(base)) {
var stream_id = base;
exports.switch_to_stream_row(stream_id);
}
};
exports.launch = function (hash) {
exports.setup_page(function () {