From 44694653ae167f45e2932801107aa5b2ef87050c Mon Sep 17 00:00:00 2001 From: Harshit Bansal Date: Fri, 10 Aug 2018 08:01:17 +0000 Subject: [PATCH] emoji: Remove `display_url` from the context of `admin_emoji_list`. This attribute seem to be artifact of some refactoring that we did but forgot to remove it. Just a minor cleanup. --- frontend_tests/node_tests/dispatch.js | 2 +- frontend_tests/node_tests/templates.js | 1 - static/js/settings_emoji.js | 1 - 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/frontend_tests/node_tests/dispatch.js b/frontend_tests/node_tests/dispatch.js index 0c761c8cf0..81b5852010 100644 --- a/frontend_tests/node_tests/dispatch.js +++ b/frontend_tests/node_tests/dispatch.js @@ -272,7 +272,7 @@ var event_fixtures = { type: 'realm_emoji', realm_emoji: { airplane: { - display_url: 'some_url', + source_url: 'some_url', }, }, }, diff --git a/frontend_tests/node_tests/templates.js b/frontend_tests/node_tests/templates.js index c12a997172..6bda6eb789 100644 --- a/frontend_tests/node_tests/templates.js +++ b/frontend_tests/node_tests/templates.js @@ -172,7 +172,6 @@ run_test('admin_emoji_list', () => { emoji: { name: "MouseFace", display_name: "MouseFace", - display_url: "http://emojipedia-us.s3.amazonaws.com/cache/46/7f/467fe69069c408e07517621f263ea9b5.png", source_url: "http://emojipedia-us.s3.amazonaws.com/cache/46/7f/467fe69069c408e07517621f263ea9b5.png", }, }; diff --git a/static/js/settings_emoji.js b/static/js/settings_emoji.js index f06b7158b7..d8601aa7d8 100644 --- a/static/js/settings_emoji.js +++ b/static/js/settings_emoji.js @@ -67,7 +67,6 @@ exports.populate_emoji = function (emoji_data) { name: data.name, display_name: data.name.replace(/_/g, ' '), source_url: data.source_url, - display_url: data.source_url, author: data.author || '', can_admin_emoji: can_admin_emoji(data), },