Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

tests: Fix test coverage on recent commit. 

I guess `test_classes` has 100% line coverage
enforcement, which is a bit tricky for error
handling.

This fixes that, as well as making the name
snake_case and improving the format of the
errors.
This commit is contained in:
Steve Howell 2020-03-19 15:32:24 +00:00 committed by showell
parent 80acbb9fdf
commit 42ee2f5e86
2 changed files with 21 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
zerver/lib/test_classes.py
View File

@ -821,7 +821,7 @@ class ZulipTestCase(TestCase):
r for r in data r for r in data
if r['id'] == db_id][0] if r['id'] == db_id][0]
def findOne(self, def find_one(self,
lst: List[Any], lst: List[Any],
predicate: Callable[[Any], bool], predicate: Callable[[Any], bool],
member_name: str) -> Any: member_name: str) -> Any:
@ -834,10 +834,14 @@ class ZulipTestCase(TestCase):
# Happy path! # Happy path!
return matches[0] return matches[0]
if True: # nocoverage
print('\nERROR: findOne fails on this list:\n') print('\nERROR: findOne fails on this list:\n')
print('[')
for item in lst: for item in lst:
print(item) print(' ', item, ',')
print(']')
if len(matches) == 0: if len(matches) == 0:
raise ValueError( raise ValueError(

2
zerver/tests/test_users.py
View File

@ -1387,7 +1387,7 @@ class GetProfileTest(ZulipTestCase):
result = self.api_get(hamlet, "/api/v1/users") result = self.api_get(hamlet, "/api/v1/users")
self.assert_json_success(result) self.assert_json_success(result)
my_user = self.findOne( my_user = self.find_one(
result.json()['members'], result.json()['members'],
lambda user: user['email'] == hamlet.email, lambda user: user['email'] == hamlet.email,
'member for Hamlet' 'member for Hamlet'