diff --git a/zerver/lib/actions.py b/zerver/lib/actions.py index 00f3f62c7a..cbeab82363 100644 --- a/zerver/lib/actions.py +++ b/zerver/lib/actions.py @@ -1973,27 +1973,27 @@ def do_send_messages( else: user_list = list(user_ids) - users: List[Dict[str, Union[int, List[str], bool]]] = [] + user_data_objects: List[UserMessageNotificationsData] = [] for user_id in user_list: flags = user_flags.get(user_id, []) wildcard_mention_notify = ( user_id in send_request.wildcard_mention_user_ids and "wildcard_mentioned" in flags ) - users.append( - asdict( - UserMessageNotificationsData( - id=user_id, - flags=flags, - mentioned=("mentioned" in flags), - online_push_enabled=(user_id in send_request.online_push_user_ids), - stream_push_notify=(user_id in send_request.stream_push_user_ids), - stream_email_notify=(user_id in send_request.stream_email_user_ids), - wildcard_mention_notify=wildcard_mention_notify, - sender_is_muted=(user_id in send_request.muted_sender_user_ids), - ) + user_data_objects.append( + UserMessageNotificationsData( + id=user_id, + flags=flags, + mentioned=("mentioned" in flags), + online_push_enabled=(user_id in send_request.online_push_user_ids), + stream_push_notify=(user_id in send_request.stream_push_user_ids), + stream_email_notify=(user_id in send_request.stream_email_user_ids), + wildcard_mention_notify=wildcard_mention_notify, + sender_is_muted=(user_id in send_request.muted_sender_user_ids), ) ) + users = [asdict(user_data_object) for user_data_object in user_data_objects] + if send_request.message.is_stream_message(): # Note: This is where authorization for single-stream # get_updates happens! We only attach stream data to the