Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

casper: Remove left-arrow message-edit tests. 

These tests have been notoriously brittle over time.
I think the problem here was knowing whether the
compose box was open or not.
This commit is contained in:
Steve Howell 2020-03-26 17:06:20 +00:00 committed by showell
parent 19b806d6c2
commit 41f0069a08
1 changed files with 0 additions and 57 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

57
frontend_tests/casper_tests/08-edit.js
View File

@ -99,63 +99,6 @@ casper.then(function () {
});
});
// test editing last own message
// 37 is left arrow key code
casper.then(function () {
casper.test.assertNotVisible('form.message_edit_form', 'Message edit box not visible');
casper.waitUntilVisible(".message_edit_notice", function () {
common.keypress(37);
});
});
casper.then(function () {
casper.waitUntilVisible(".message_edit_content", function () {
var fieldVal = common.get_form_field_value('.message_edit_content');
casper.test.assertEquals(fieldVal, "test edited pm", "Opened editing last own message");
casper.click('.message_edit_cancel');
});
});
casper.then(function () {
casper.waitWhileVisible('.message_edit', function () {
casper.click('body');
casper.page.sendEvent('keypress', "c");
});
});
casper.then(function () {
casper.waitUntilVisible('#compose', function () {
casper.evaluate(function () {
$('#compose-textarea').expectOne().focus();
$('#compose-textarea').trigger($.Event('keydown', { which: 37 }));
});
});
});
casper.then(function () {
casper.waitUntilVisible(".message_edit_form", function () {
casper.echo("Opened editing last own message");
casper.click('.message_edit_cancel');
});
});
casper.then(function () {
casper.waitWhileVisible('.message_edit', function () {
casper.click('body');
casper.page.sendEvent('keypress', "c");
});
});
casper.then(function () {
casper.waitUntilVisible('#compose', function () {
casper.evaluate(function () {
$('#compose-textarea').expectOne().focus().val('test');
$('#compose-textarea').trigger($.Event('keydown', { which: 37 }));
});
casper.test.assertNotVisible('form.message_edit_form', "Last own message edit doesn't open if the compose box not empty");
});
});
casper.run(function () {
casper.test.done();
});