Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

message_edit: Use sets for old/new stream IDs. 

This fixes a quadratic performance issue iterating through these
lists. Give these variables slightly better names while we're at it.
This commit is contained in:
Tim Abbott 2023-04-20 17:19:59 -07:00
parent 496b403fcf
commit 3ff361a1f0
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
zerver/actions/message_edit.py
View File

@ -524,12 +524,12 @@ def do_update_message(
).select_related("user_profile") ).select_related("user_profile")
) )
old_stream_sub_ids = [user.user_profile_id for user in subs_to_old_stream] old_stream_user_ids = {user.user_profile_id for user in subs_to_old_stream}
new_stream_sub_ids = [user.user_profile_id for user in subs_to_new_stream] new_stream_user_ids = {user.user_profile_id for user in subs_to_new_stream}
# Get users who aren't subscribed to the new_stream. # Get users who aren't subscribed to the new_stream.
subs_losing_usermessages = [ subs_losing_usermessages = [
sub for sub in subs_to_old_stream if sub.user_profile_id not in new_stream_sub_ids sub for sub in subs_to_old_stream if sub.user_profile_id not in new_stream_user_ids
] ]
# Users who can longer access the message without some action # Users who can longer access the message without some action
# from administrators. # from administrators.
@ -549,7 +549,7 @@ def do_update_message(
# and create new UserMessage for these users so that they can # and create new UserMessage for these users so that they can
# access this message. # access this message.
subs_gaining_usermessages += [ subs_gaining_usermessages += [
user_id for user_id in new_stream_sub_ids if user_id not in old_stream_sub_ids user_id for user_id in new_stream_user_ids if user_id not in old_stream_user_ids
] ]
# We save the full topic name so that checks that require comparison # We save the full topic name so that checks that require comparison