Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

message_view_header: Remove unnecessary complexity. 

The narrow_state module has a function that returns what this needs.

This does remove a log statement, but I don't think it was useful; we
don't need to or have a useful way to colorize a channel that doesn't
exist.
This commit is contained in:
Tim Abbott 2024-10-02 11:55:37 -07:00
parent 359ebfc6c8
commit 3f307f5941
1 changed files with 1 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
web/src/message_view_header.ts
View File

@ -3,7 +3,6 @@ import assert from "minimalistic-assert";
import render_message_view_header from "../templates/message_view_header.hbs"; import render_message_view_header from "../templates/message_view_header.hbs";
import * as blueslip from "./blueslip";
import type {Filter} from "./filter"; import type {Filter} from "./filter";
import * as hash_util from "./hash_util"; import * as hash_util from "./hash_util";
import {$t} from "./i18n"; import {$t} from "./i18n";
@ -131,17 +130,7 @@ function get_message_view_header_context(filter: Filter | undefined): MessageVie
} }
export function colorize_message_view_header(): void { export function colorize_message_view_header(): void {
const filter = narrow_state.filter(); const current_sub = narrow_state.stream_sub();
let current_sub;
if (filter?.has_operator("channel")) {
current_sub = stream_data.get_sub_by_id_string(filter.operands("channel")[0]!);
if (current_sub === undefined) {
blueslip.error("Unexpected undefined sub", {
stream_id: filter.operands("channel")[0],
filter,
});
}
}
if (!current_sub) { if (!current_sub) {
return; return;
} }