Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

settings: Simplify testing push bouncer. 

We already override PUSH_NOTIFICATION_BOUNCER_URL in
test_extra_settings.py, so making this change should have as its only
impact making it a bit easier to test the push notifications bouncer
manually in a development environment.

I submitted a related PR to the mobile app documentation for testing
the push notifications software against a production server motivated
by this.
This commit is contained in:
Tim Abbott 2023-12-10 16:29:57 -08:00
parent f78db57c6b
commit 3dc886a1cd
2 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
zproject/dev_settings.py
View File

@ -208,10 +208,5 @@ SCIM_CONFIG: Dict[str, SCIMConfigDict] = {
} }
SELF_HOSTING_MANAGEMENT_SUBDOMAIN = "selfhosting" SELF_HOSTING_MANAGEMENT_SUBDOMAIN = "selfhosting"
DEVELOPMENT_DISABLE_PUSH_BOUNCER_DOMAIN_CHECK = True
# You can uncomment these lines to use the development environment PUSH_NOTIFICATION_BOUNCER_URL = f"http://push.{EXTERNAL_HOST}"
# server as a dummy push bouncer for itself, to test functionalities
# such as register_server or update_analytics_counts management commands
# or others involving new bouncer-side logic.
# DEVELOPMENT_DISABLE_PUSH_BOUNCER_DOMAIN_CHECK = True
# PUSH_NOTIFICATION_BOUNCER_URL = "http://localhost:9991"

1
zproject/test_extra_settings.py
View File

@ -204,6 +204,7 @@ BIG_BLUE_BUTTON_URL = "https://bbb.example.com/bigbluebutton/"
# Explicitly set this to True within tests that must have this on. # Explicitly set this to True within tests that must have this on.
TWO_FACTOR_AUTHENTICATION_ENABLED = False TWO_FACTOR_AUTHENTICATION_ENABLED = False
PUSH_NOTIFICATION_BOUNCER_URL: Optional[str] = None PUSH_NOTIFICATION_BOUNCER_URL: Optional[str] = None
DEVELOPMENT_DISABLE_PUSH_BOUNCER_DOMAIN_CHECK = False
# Logging the emails while running the tests adds them # Logging the emails while running the tests adds them
# to /emails page. # to /emails page.