Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

billing: Remove idempotency key from upgrade process. 

This would be relevant if we retried on network failure, but we don't.
This commit is contained in:
Rishi Gupta 2018-08-22 18:36:03 -07:00
parent e784c95d97
commit 3cf9cd00d6
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
stubs/stripe/__init__.pyi
View File

@ -23,7 +23,7 @@ class Customer:
... ...
@staticmethod @staticmethod
def save(idempotency_key: str) -> Customer: def save() -> Customer:
... ...
class Invoice: class Invoice:

4
zilencer/lib/stripe.py
View File

@ -165,9 +165,7 @@ def do_replace_payment_source(user: UserProfile, stripe_token: str) -> stripe.Cu
# Deletes existing card: https://stripe.com/docs/api#update_customer-source # Deletes existing card: https://stripe.com/docs/api#update_customer-source
# This can also have other side effects, e.g. it will try to pay certain past-due # This can also have other side effects, e.g. it will try to pay certain past-due
# invoices: https://stripe.com/docs/api#update_customer # invoices: https://stripe.com/docs/api#update_customer
updated_stripe_customer = stripe_customer.save( updated_stripe_customer = stripe_customer.save()
# stripe_token[:4] = 'tok_', so 8 characters of entropy
idempotency_key='do_replace_payment_source:%s' % (stripe_token[:12]))
RealmAuditLog.objects.create( RealmAuditLog.objects.create(
realm=user.realm, acting_user=user, event_type=RealmAuditLog.STRIPE_CARD_ADDED, realm=user.realm, acting_user=user, event_type=RealmAuditLog.STRIPE_CARD_ADDED,
event_time=timezone_now()) event_time=timezone_now())