Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

setup_venv: Fix missing libssl-dev dependency. 

We were already correctly including libssl-dev in Zulip's dependencies
in development environment provisioning, but (at least now) it's
needed to build certain Python packages like pycurl when building a
Zulip virtualenv in production.  I haven't investigated why we didn't
need this on Ubuntu, but one possible reason would be that some other
library in our dependencies list happens to depend on it on Ubuntu.

We fix this by moving the dependency over to the shared
VENV_DEPENDENCIES list.

Fixes part of #9946.
This commit is contained in:
Tim Abbott 2018-07-13 17:15:20 +05:30
parent 8f9b5633b8
commit 3cc93fd721
2 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
scripts/lib/setup_venv.py
View File

@ -35,6 +35,7 @@ VENV_DEPENDENCIES = [
"libxml2-dev", # Used for installing talon "libxml2-dev", # Used for installing talon
"libxslt1-dev", # Used for installing talon "libxslt1-dev", # Used for installing talon
"libpq-dev", # Needed by psycopg2 "libpq-dev", # Needed by psycopg2
"libssl-dev", # Needed to build pycurl and other libraries
] ]
codename = parse_lsb_release()["DISTRIB_CODENAME"] codename = parse_lsb_release()["DISTRIB_CODENAME"]

1
tools/lib/provision.py
View File

@ -125,7 +125,6 @@ UBUNTU_COMMON_APT_DEPENDENCIES = [
"hunspell-en-us", "hunspell-en-us",
"supervisor", "supervisor",
"git", "git",
"libssl-dev",
"yui-compressor", "yui-compressor",
"wget", "wget",
"ca-certificates", # Explicit dependency in case e.g. wget is already installed "ca-certificates", # Explicit dependency in case e.g. wget is already installed