Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

install: Remove /dev/null redirect for zulip-puppet-apply. 

The usual output from this command looks like

Notice: Compiled catalog for localhost in environment production in 2.33 seconds
Notice: /Stage[main]/Zulip::Apt_repository/Exec[setup_apt_repo]/returns: current_value 'notrun', should be ['0'] (noop)
Notice: Class[Zulip::Apt_repository]: Would have triggered 'refresh' from 1 event
Notice: Stage[main]: Would have triggered 'refresh' from 1 event
Notice: Applied catalog in 1.20 seconds

which doesn’t seem abnormally alarming, and hiding it makes failures
harder to diagnose.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg 2021-08-31 15:55:40 -07:00 committed by Tim Abbott
parent 2ec5f613e2
commit 3cb66d59ac
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
scripts/lib/install
View File

@ -397,8 +397,7 @@ id -u zulip &>/dev/null || useradd -m zulip --home-dir /home/zulip
if [ -n "$NO_OVERWRITE_SETTINGS" ] && [ -e "/etc/zulip/zulip.conf" ]; then if [ -n "$NO_OVERWRITE_SETTINGS" ] && [ -e "/etc/zulip/zulip.conf" ]; then
"$ZULIP_PATH"/scripts/zulip-puppet-apply --noop \ "$ZULIP_PATH"/scripts/zulip-puppet-apply --noop \
--write-catalog-summary \ --write-catalog-summary \
--classfile=/var/lib/puppet/classes.txt \ --classfile=/var/lib/puppet/classes.txt
>/dev/null
else else
# Write out more than we need, and remove sections that are not # Write out more than we need, and remove sections that are not
# applicable to the classes that are actually necessary. # applicable to the classes that are actually necessary.
@ -421,8 +420,7 @@ EOF
"$ZULIP_PATH"/scripts/zulip-puppet-apply --noop \ "$ZULIP_PATH"/scripts/zulip-puppet-apply --noop \
--write-catalog-summary \ --write-catalog-summary \
--classfile=/var/lib/puppet/classes.txt \ --classfile=/var/lib/puppet/classes.txt
>/dev/null
# We only need the PostgreSQL version setting on database hosts; but # We only need the PostgreSQL version setting on database hosts; but
# we don't know if this is a database host until we have the catalog summary. # we don't know if this is a database host until we have the catalog summary.