Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

tools: Add support for generating integration screenshots remotely. 

I have added support for generating integration screenshots remotely by
adding a `realm_uri` parameter to `tools/message-screenshot.js` which we
then pass `realm.uri` to from within
`tools/generate-integration-docs-screenshot`.
This commit is contained in:
Adam Birds 2021-04-15 22:06:18 +00:00 committed by Tim Abbott
parent 14b01343d9
commit 3b974d9ef7
2 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tools/generate-integration-docs-screenshot
View File

@ -187,12 +187,13 @@ def send_bot_payload_message(
def capture_last_message_screenshot(bot: UserProfile, image_path: str) -> None:
message = Message.objects.filter(sender=bot).last()
realm = get_realm("zulip")
if message is None:
print(f"No message found for {bot.full_name}")
return
message_id = str(message.id)
screenshot_script = os.path.join(TOOLS_DIR, "message-screenshot.js")
subprocess.check_call(["node", screenshot_script, message_id, image_path])
subprocess.check_call(["node", screenshot_script, message_id, image_path, realm.uri])
def generate_screenshot_from_config(

10
tools/message-screenshot.js
View File

@ -9,14 +9,14 @@ require("css.escape");
const mkdirp = require("mkdirp");
const puppeteer = require("puppeteer");
const host = "localhost:9991";
const options = {};
commander
.arguments("<message_id> <image_path>")
.action((messageId, imagePath) => {
.arguments("<message_id> <image_path> <realm_uri")
.action((messageId, imagePath, realmUri) => {
options.messageId = messageId;
options.imagePath = imagePath;
options.realmUri = realmUri;
console.log(`Capturing screenshot for message ${messageId} to ${imagePath}`);
})
.parse(process.argv);
@ -43,7 +43,7 @@ async function run() {
const page = await browser.newPage();
// deviceScaleFactor:2 gives better quality screenshots (higher pixel density)
await page.setViewport({width: 1280, height: 1024, deviceScaleFactor: 2});
await page.goto("http://" + host);
await page.goto(options.realmUri);
// wait for Iago devlogin button and click on it.
await page.waitForSelector('[value="iago@zulip.com"]');
@ -54,7 +54,7 @@ async function run() {
]);
// Navigate to message and capture screenshot
await page.goto(`http://${host}/#narrow/id/${options.messageId}`);
await page.goto(`${options.realmUri}/#narrow/id/${options.messageId}`);
const messageSelector = `#zfilt${CSS.escape(options.messageId)}`;
await page.waitForSelector(messageSelector);
// remove unread marker and don't select message