Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

popovers: Fix topic visibility popover in sticky header not working. 

The popover didn't open since sticky_header is part of message feed
and we were hiding popovers if `elements_at_reference_position`
had `sticky_header`. Now, we just don't do that check if the
reference is part of sticky_header.
This commit is contained in:
Aman Agrawal 2023-11-08 03:29:30 +00:00 committed by Tim Abbott
parent f2deb8da46
commit 3a7ce432e5
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
web/src/popover_menus.js
View File

@ -180,7 +180,11 @@ export const default_popover_props = {
// hiding elements outside the message feed is tricky and expensive due to stacking context.
// References in overlays, modal, sidebar overlays, popovers, etc. can make the below logic hard
// to live with if we take elements outside message feed into account.
if ($reference.parents("#message_feed_container").length !== 1) {
// Since `.sticky_header` is inside `#message_feed_container`, we allow popovers from reference inside
// `.sticky_header` to be visible.
if (
$reference.parents("#message_feed_container, .sticky_header").length !== 1
) {
return;
}