From 3a64c8c0db0082bcd7a36654ab0a8523c28f553f Mon Sep 17 00:00:00 2001 From: N-Shar-ma Date: Wed, 12 Apr 2023 18:41:42 +0530 Subject: [PATCH] compose: Change video call url text to "Join video call.". Earlier it was "Click here to join video call". --- help/start-a-call.md | 8 +++----- web/src/compose.js | 2 +- web/tests/compose_video.test.js | 6 +++--- 3 files changed, 7 insertions(+), 9 deletions(-) diff --git a/help/start-a-call.md b/help/start-a-call.md index 0d8af57e8d..2e0c080b7c 100644 --- a/help/start-a-call.md +++ b/help/start-a-call.md @@ -4,10 +4,8 @@ {!start-composing.md!} -1. Click the **video-camera** () icon in the -bottom left corner of the compose box. This will insert a link like -**[Click to join video call]\(https://meet.jit.si/123456789)** into the -compose box. +1. Click the **video camera** () at the bottom of +the compose box. This will insert a **Join video call.** link into your message. 1. Send the message. @@ -15,7 +13,7 @@ compose box. !!! tip "" - You can replace "Click to join video call" with anything you want. + You can replace the "Join video call." label for the link with any text you like. {end_tabs} diff --git a/web/src/compose.js b/web/src/compose.js index fe5bccb4b8..6341481a23 100644 --- a/web/src/compose.js +++ b/web/src/compose.js @@ -380,7 +380,7 @@ export function update_email(user_id, new_email) { } function insert_video_call_url(url, target_textarea) { - const link_text = $t({defaultMessage: "Click to join video call"}); + const link_text = $t({defaultMessage: "Join video call."}); compose_ui.insert_syntax_and_focus(`[${link_text}](${url})`, target_textarea, "block", 1); } diff --git a/web/tests/compose_video.test.js b/web/tests/compose_video.test.js index 73c4408c69..711a0a4165 100644 --- a/web/tests/compose_video.test.js +++ b/web/tests/compose_video.test.js @@ -130,7 +130,7 @@ test("videos", ({override}) => { handler(ev); // video link ids consist of 15 random digits const video_link_regex = - /\[translated: Click to join video call]\(https:\/\/meet.jit.si\/\d{15}\)/; + /\[translated: Join video call\.]\(https:\/\/meet.jit.si\/\d{15}\)/; assert.ok(called); assert.match(syntax_to_insert, video_link_regex); })(); @@ -176,7 +176,7 @@ test("videos", ({override}) => { }; handler(ev); - const video_link_regex = /\[translated: Click to join video call]\(example\.zoom\.com\)/; + const video_link_regex = /\[translated: Join video call\.]\(example\.zoom\.com\)/; assert.ok(called); assert.match(syntax_to_insert, video_link_regex); })(); @@ -219,7 +219,7 @@ test("videos", ({override}) => { handler(ev); const video_link_regex = - /\[translated: Click to join video call]\(\/calls\/bigbluebutton\/join\?meeting_id=%22zulip-1%22&password=%22AAAAAAAAAA%22&checksum=%2232702220bff2a22a44aee72e96cfdb4c4091752e%22\)/; + /\[translated: Join video call\.]\(\/calls\/bigbluebutton\/join\?meeting_id=%22zulip-1%22&password=%22AAAAAAAAAA%22&checksum=%2232702220bff2a22a44aee72e96cfdb4c4091752e%22\)/; assert.ok(called); assert.match(syntax_to_insert, video_link_regex); })();