Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

test_typing: Replace 'private' with 'direct'. 

This commit replaces the keyword 'private' with 'direct'.

'pm' has been changed to 'direct message' to be more verbose.
This commit is contained in:
Prakhar Pratyush 2023-10-07 16:12:49 +05:30 committed by Tim Abbott
parent 8d8b6ef156
commit 39ec5b9f66
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
zerver/tests/test_typing.py
View File

@ -16,7 +16,7 @@ class TypingValidateOperatorTest(ZulipTestCase):
result = self.api_post(sender, "/api/v1/typing", params) result = self.api_post(sender, "/api/v1/typing", params)
self.assert_json_error(result, "Missing 'op' argument") self.assert_json_error(result, "Missing 'op' argument")
def test_invalid_parameter_pm(self) -> None: def test_invalid_parameter_direct_message(self) -> None:
""" """
Sending typing notification with invalid value for op parameter fails Sending typing notification with invalid value for op parameter fails
""" """
@ -50,9 +50,9 @@ class TypingMessagetypeTest(ZulipTestCase):
class TypingValidateToArgumentsTest(ZulipTestCase): class TypingValidateToArgumentsTest(ZulipTestCase):
def test_empty_to_array_pms(self) -> None: def test_empty_to_array_direct_messages(self) -> None:
""" """
Sending pms typing notification without recipient fails Sending dms typing notification without recipient fails
""" """
sender = self.example_user("hamlet") sender = self.example_user("hamlet")
result = self.api_post(sender, "/api/v1/typing", {"op": "start", "to": "[]"}) result = self.api_post(sender, "/api/v1/typing", {"op": "start", "to": "[]"})
@ -131,7 +131,7 @@ class TypingValidateToArgumentsTest(ZulipTestCase):
self.assert_json_error(result, "Invalid stream ID") self.assert_json_error(result, "Invalid stream ID")
class TypingHappyPathTestPMs(ZulipTestCase): class TypingHappyPathTestDirectMessages(ZulipTestCase):
def test_valid_type_and_op_parameters(self) -> None: def test_valid_type_and_op_parameters(self) -> None:
operator_type = ["start", "stop"] operator_type = ["start", "stop"]
sender = self.example_user("hamlet") sender = self.example_user("hamlet")