From 3920a73b2056bee928e0411fe1a94dce5516379a Mon Sep 17 00:00:00 2001
From: Sahil Batra <sahil@zulip.com>
Date: Wed, 11 Jan 2023 17:28:47 +0530
Subject: [PATCH] social_auth_select_email: Remove form-horizontal class.

This commit removes form-horizontal class from form elements
in social_auth_select_email.html. There is no visible input
element in the form element so the bootstrap CSS using
"form-horizontal" class does not apply to any of the elments
in the page, so removing this class does not have any affect.

The "form-horizontal" class is used in portico-signin.css for
adding hover behavior, so we add a new class "select-email-form"
and use it to add the hover behavior.
---
 static/styles/portico/portico_signin.css       | 2 +-
 templates/zerver/social_auth_select_email.html | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/static/styles/portico/portico_signin.css b/static/styles/portico/portico_signin.css
index 77434f2cd5..5eb0ff3d63 100644
--- a/static/styles/portico/portico_signin.css
+++ b/static/styles/portico/portico_signin.css
@@ -1095,7 +1095,7 @@ button#register_auth_button_gitlab {
         padding: 0;
         margin: 0;
 
-        &.form-horizontal:hover {
+        &.select-email-form:hover {
             background-color: hsl(202, 56%, 91%);
             cursor: pointer;
 
diff --git a/templates/zerver/social_auth_select_email.html b/templates/zerver/social_auth_select_email.html
index 55f8cbafba..88f8665ffe 100644
--- a/templates/zerver/social_auth_select_email.html
+++ b/templates/zerver/social_auth_select_email.html
@@ -13,7 +13,7 @@
     </div>
 
     <div class="white-box">
-        <form method="post" class="form-horizontal" action="/complete/{{ backend }}/">
+        <form method="post" class="select-email-form" action="/complete/{{ backend }}/">
             <div class="choose-email-box">
                 <input type="hidden" name="email" value="{{ primary_email }}" />
                 {% if avatar_urls[primary_email] %}
@@ -37,7 +37,7 @@
             </div>
         </form>
         {% for email in verified_non_primary_emails %}
-        <form method="post" class="form-horizontal" action="/complete/{{ backend }}/">
+        <form method="post" class="select-email-form" action="/complete/{{ backend }}/">
             <div class="choose-email-box">
                 <input type="hidden" name="email" value="{{ email }}" />
                 {% if avatar_urls[email] %}