From 3829ab0ea9556b8cfaecbdd9046201244a424126 Mon Sep 17 00:00:00 2001 From: Steve Howell Date: Sun, 21 Feb 2021 11:44:39 +0000 Subject: [PATCH] node tests: Fix zjquery leaks for popovers. --- frontend_tests/node_tests/popovers.js | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/frontend_tests/node_tests/popovers.js b/frontend_tests/node_tests/popovers.js index e4f294523c..6db0f8dfc8 100644 --- a/frontend_tests/node_tests/popovers.js +++ b/frontend_tests/node_tests/popovers.js @@ -71,11 +71,6 @@ const me = { timezone: "America/Los_Angeles", }; -const target = $.create("click target"); -target.offset = () => ({ - top: 10, -}); - const e = { stopPropagation: noop, }; @@ -111,9 +106,15 @@ function make_image_stubber() { }; } -popovers.register_click_handlers(); +function test_ui(label, f) { + $.clear_all_elements(); + run_test(label, (override) => { + popovers.register_click_handlers(); + f(override); + }); +} -run_test("sender_hover", (override) => { +test_ui("sender_hover", (override) => { override(popovers, "hide_user_profile", noop); const selection = ".sender_name, .sender_name-in-status, .inline_profile_picture"; @@ -140,6 +141,8 @@ run_test("sender_hover", (override) => { assert.equal(msg_id, message.id); }; + const target = $.create("click target"); + target.closest = (sel) => { assert.equal(sel, ".message_row"); return {}; @@ -206,7 +209,9 @@ run_test("sender_hover", (override) => { // todo: load image }); -run_test("actions_popover", (override) => { +test_ui("actions_popover", (override) => { + const target = $.create("click target"); + override(popovers, "hide_user_profile", noop); const handler = $("#main_div").get_on_handler("click", ".actions_hover");