Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

eslint: Forbid unchecked casts in TypeScript. 

Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg 2023-10-25 19:41:09 -07:00 committed by Tim Abbott
parent 2f95c55df4
commit 37f0a3b41b
2 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
.eslintrc.json
View File

@ -172,6 +172,10 @@
// Disable base rule to avoid conflict // Disable base rule to avoid conflict
"no-use-before-define": "off", "no-use-before-define": "off",
"@typescript-eslint/consistent-type-assertions": [
"error",
{"assertionStyle": "never"}
],
"@typescript-eslint/consistent-type-definitions": ["error", "type"], "@typescript-eslint/consistent-type-definitions": ["error", "type"],
"@typescript-eslint/consistent-type-imports": "error", "@typescript-eslint/consistent-type-imports": "error",
"@typescript-eslint/explicit-function-return-type": [ "@typescript-eslint/explicit-function-return-type": [

3
web/debug-require-webpack-plugin.ts
View File

@ -22,6 +22,7 @@ export default class DebugRequirePlugin implements WebpackPluginInstance {
.tap("DebugRequirePlugin", (resolver) => { .tap("DebugRequirePlugin", (resolver) => {
resolver.getHook("beforeRawModule").tap("DebugRequirePlugin", (req) => { resolver.getHook("beforeRawModule").tap("DebugRequirePlugin", (req) => {
if (!(nameSymbol in req)) { if (!(nameSymbol in req)) {
// eslint-disable-next-line @typescript-eslint/consistent-type-assertions
(req as NamedRequest)[nameSymbol] = req.request; (req as NamedRequest)[nameSymbol] = req.request;
} }
return undefined!; return undefined!;
@ -31,6 +32,7 @@ export default class DebugRequirePlugin implements WebpackPluginInstance {
if (req.path !== false) { if (req.path !== false) {
const inPath = path.relative(compiler.context, req.path); const inPath = path.relative(compiler.context, req.path);
if (!inPath.startsWith("../") && !(nameSymbol in req)) { if (!inPath.startsWith("../") && !(nameSymbol in req)) {
// eslint-disable-next-line @typescript-eslint/consistent-type-assertions
(req as NamedRequest)[nameSymbol] = "./" + inPath; (req as NamedRequest)[nameSymbol] = "./" + inPath;
} }
} }
@ -40,6 +42,7 @@ export default class DebugRequirePlugin implements WebpackPluginInstance {
resolver resolver
.getHook("beforeResolved") .getHook("beforeResolved")
.tap("DebugRequirePlugin", (req: ResolveRequest) => { .tap("DebugRequirePlugin", (req: ResolveRequest) => {
// eslint-disable-next-line @typescript-eslint/consistent-type-assertions
const name = (req as NamedRequest)[nameSymbol]; const name = (req as NamedRequest)[nameSymbol];
if (name !== undefined && req.path !== false) { if (name !== undefined && req.path !== false) {
const names = resolved.get(req.path); const names = resolved.get(req.path);