Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

people: Clean up now-unnecessary url variable.

This commit is contained in:
Tim Abbott 2018-04-05 12:40:05 -07:00
parent 40421c5000
commit 37a83285c4
1 changed files with 2 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
static/js/people.js
View File

@ -512,9 +512,7 @@ exports.small_avatar_url = function (message) {
// We actually request these at s=50, so that we look better // We actually request these at s=50, so that we look better
// on retina displays. // on retina displays.
var url = "";
var person; var person;
if (message.sender_id) { if (message.sender_id) {
// We should always have message.sender_id, except for in the // We should always have message.sender_id, except for in the
// tutorial, where it's ok to fall back to the url in the fake // tutorial, where it's ok to fall back to the url in the fake
@ -531,7 +529,7 @@ exports.small_avatar_url = function (message) {
// Try to get info from the message if we didn't have a `person` object // Try to get info from the message if we didn't have a `person` object
// or if the avatar was missing. We do this verbosely to avoid false // or if the avatar was missing. We do this verbosely to avoid false
// positives on line coverage (we don't do branch checking). // positives on line coverage (we don't do branch checking).
if (!url && message.avatar_url) { if (message.avatar_url) {
return exports.format_small_avatar_url(message.avatar_url); return exports.format_small_avatar_url(message.avatar_url);
} }
@ -545,15 +543,7 @@ exports.small_avatar_url = function (message) {
email = message.sender_email; email = message.sender_email;
} }
if (!url) { return gravatar_url_for_email(email);
return gravatar_url_for_email(email);
}
if (url) {
url = exports.format_small_avatar_url(url);
}
return url;
}; };
exports.is_valid_email_for_compose = function (email) { exports.is_valid_email_for_compose = function (email) {