Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

left sidebar: Add a bit of margin below stream list. 

Having a tiny bit of margin below the stream list
makes it possible to see the bottom of the scrollbar.

It also makes it so that the scrollbar activates
for a tiny range of list sizes where before the
last element would have been right up against the
bottom of the page, but we wouldn't scroll.
This commit is contained in:
Steve Howell 2019-02-08 11:47:32 +00:00 committed by Tim Abbott
parent a6c2c16666
commit 3649293d71
2 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
static/js/resize.js
View File

@ -58,7 +58,8 @@ function get_new_heights() {
res.bottom_sidebar_height = viewport_height
- parseInt($("#left-sidebar").css("marginTop"), 10)
- parseInt($(".bottom_sidebar").css("marginTop"), 10);
- parseInt($(".bottom_sidebar").css("marginTop"), 10)
- parseInt($(".bottom_sidebar").css("marginBottom"), 10);
res.right_sidebar_height = viewport_height - parseInt($("#right-sidebar").css("marginTop"), 10);
@ -123,7 +124,8 @@ function left_userlist_get_new_heights() {
res.bottom_sidebar_height = viewport_height
- parseInt($("#left-sidebar").css("marginTop"), 10)
- parseInt($(".bottom_sidebar").css("marginTop"), 10);
- parseInt($(".bottom_sidebar").css("marginTop"), 10)
- parseInt($(".bottom_sidebar").css("marginBottom"), 10);
res.total_leftlist_height = res.bottom_sidebar_height

7
static/styles/left-sidebar.scss
View File

@ -47,11 +47,16 @@
#stream_filters {
overflow: visible;
/* The -1px here prevents the scrollbar from going above the top of the container */
margin: -1px 0px 22px 0px;
margin-top: -1px;
margin-bottom: 18px;
padding: 0;
font-weight: normal;
}
.bottom_sidebar {
margin-bottom: 4px;
}
.left-sidebar li {
margin: 1px 0px;
}