Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

tools/run-mypy: Use mypy from zulip-py3-venv if present.

This commit is contained in:
Eklavya Sharma 2016-04-27 12:58:20 +05:30 committed by Tim Abbott
parent c80f699321
commit 3601b9eda9
1 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
tools/run-mypy
View File

@ -3,10 +3,12 @@
from __future__ import print_function from __future__ import print_function
import os import os
from os.path import dirname, abspath
import sys import sys
import lister import lister
import argparse import argparse
import subprocess import subprocess
import six
exclude=""" exclude="""
api/integrations/ api/integrations/
@ -45,13 +47,24 @@ if args.all:
python_files = lister.list_files(targets=args.targets, ftypes=['py'], use_shebang=False, python_files = lister.list_files(targets=args.targets, ftypes=['py'], use_shebang=False,
modified_only=args.modified, exclude=exclude) modified_only=args.modified, exclude=exclude)
# Use zulip-py3-venv's mypy if it's available and we're on python 2
PY3_VENV_DIR = "/srv/zulip-py3-venv"
MYPY_VENV_PATH = os.path.join(PY3_VENV_DIR, "bin", "mypy")
if six.PY2 and os.path.exists(MYPY_VENV_PATH):
mypy_command = MYPY_VENV_PATH
print("Using mypy from", mypy_command)
else:
mypy_command = "mypy"
if python_files: if python_files:
rc = subprocess.call(["mypy", "--silent", "--py2", "--check-untyped-defs"] + python_files) rc = subprocess.call([mypy_command, "--silent", "--py2", "--check-untyped-defs"] + python_files)
if not rc: if not rc:
print("The mypy static type checker for python detected no errors!") print("The mypy static type checker for python detected no errors!")
else: else:
print("\nThe mypy static type checker for Python threw some errors,") print("\nThe mypy static type checker for Python threw some errors,")
print("which indicates a bug in your code or incorrect type annotations.") print("which indicates a bug in your code or incorrect type annotations.")
print("Please see docs/mypy.md for details on how Zulip is using mypy")
print("to find bugs and how to debug the issue.")
sys.exit(rc) sys.exit(rc)
else: else:
print("There are no files to run mypy on.") print("There are no files to run mypy on.")