From 3554afde3652e7975c69bfe84596efd3ad072435 Mon Sep 17 00:00:00 2001 From: Tim Abbott Date: Fri, 11 Oct 2024 16:00:38 -0700 Subject: [PATCH] api docs: Document can_manage_all_groups final semantics. This also does the feature level 305 stamp. --- api_docs/changelog.md | 5 +++++ version.py | 2 +- zerver/openapi/zulip.yaml | 16 ++++++---------- 3 files changed, 12 insertions(+), 11 deletions(-) diff --git a/api_docs/changelog.md b/api_docs/changelog.md index 3889ff3a0b..548274cadd 100644 --- a/api_docs/changelog.md +++ b/api_docs/changelog.md @@ -31,6 +31,11 @@ format used by the Zulip server that they are interacting with. * [`PATCH /user_groups/{user_group_id}`](/api/update-user-group): Added `can_add_members_group` parameter to support changing the user group which can add members to the specified user group. +* The `can_manage_all_groups` permission now has the natural semantics + of applying to all groups, regardless of the role of the user given + this permission. Since its introduction in feature level 299, + `can_manage_all_groups` had temporarily had unusual semantics + matching those of the original`user_group_edit_policy` setting. **Feature level 304** diff --git a/version.py b/version.py index 64f1f0712a..3d114cb7f2 100644 --- a/version.py +++ b/version.py @@ -34,7 +34,7 @@ DESKTOP_WARNING_VERSION = "5.9.3" # new level means in api_docs/changelog.md, as well as "**Changes**" # entries in the endpoint's documentation in `zulip.yaml`. -API_FEATURE_LEVEL = 304 # Last bumped for adding `export_type` field. +API_FEATURE_LEVEL = 305 # Last bumped for adding can_add_members_group to usergroup. # Bump the minor PROVISION_VERSION to indicate that folks should provision # only when going from an old version of the code to a newer version. Bump diff --git a/zerver/openapi/zulip.yaml b/zerver/openapi/zulip.yaml index deb76d6b0f..be32eae2aa 100644 --- a/zerver/openapi/zulip.yaml +++ b/zerver/openapi/zulip.yaml @@ -4395,11 +4395,9 @@ paths: defining the set of users who have permission to administer all existing groups in this organization. - **Changes**: Semantics to change in Zulip 10.0 (feature - level TBD). The original implementation of this setting - had different semantics, where only users who were a - member of the group or had the moderator role or above - could exercise the permission. + **Changes**: Prior to Zulip 10.0 (feature level 305), only users who + were a member of the group or had the moderator role or above could + exercise the permission on a given group. New in Zulip 10.0 (feature level 299). Previously the `user_group_edit_policy` field controlled the permission @@ -16279,11 +16277,9 @@ paths: defining the set of users who have permission to administer all existing groups in this organization. - **Changes**: Semantics to change in Zulip 10.0 (feature - level TBD). The original implementation of this setting - had different semantics, where only users who were a - member of the group or had the moderator role or above - could exercise the permission. + **Changes**: Prior to Zulip 10.0 (feature level 305), only users who + were a member of the group or had the moderator role or above could + exercise the permission on a given group. New in Zulip 10.0 (feature level 299). Previously the `user_group_edit_policy` field controlled the permission