Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

user_card_popover: Rename `_title` suffix to `_avatar`.

This commit is contained in:
Aman Agrawal 2023-10-04 21:38:03 +00:00 committed by Tim Abbott
parent 78543a7f12
commit 3415a6898c
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tools/linter_lib/custom_check.py
View File

@ -694,7 +694,7 @@ html_rules: List["Rule"] = [
"templates/corporate/billing.html", "templates/corporate/billing.html",
"templates/corporate/upgrade.html", "templates/corporate/upgrade.html",
# Miscellaneous violations to be cleaned up # Miscellaneous violations to be cleaned up
"web/templates/user_card_popover_title.hbs", "web/templates/user_card_popover_avatar.hbs",
"web/templates/confirm_dialog/confirm_subscription_invites_warning.hbs", "web/templates/confirm_dialog/confirm_subscription_invites_warning.hbs",
"templates/zerver/reset_confirm.html", "templates/zerver/reset_confirm.html",
"templates/zerver/config_error.html", "templates/zerver/config_error.html",

4
web/src/user_card_popover.js
View File

@ -4,9 +4,9 @@ import $ from "jquery";
import tippy from "tippy.js"; import tippy from "tippy.js";
import render_confirm_mute_user from "../templates/confirm_dialog/confirm_mute_user.hbs"; import render_confirm_mute_user from "../templates/confirm_dialog/confirm_mute_user.hbs";
import render_user_card_popover_avatar from "../templates/user_card_popover_avatar.hbs";
import render_user_card_popover_content from "../templates/user_card_popover_content.hbs"; import render_user_card_popover_content from "../templates/user_card_popover_content.hbs";
import render_user_card_popover_manage_menu from "../templates/user_card_popover_manage_menu.hbs"; import render_user_card_popover_manage_menu from "../templates/user_card_popover_manage_menu.hbs";
import render_user_card_popover_title from "../templates/user_card_popover_title.hbs";
import * as blueslip from "./blueslip"; import * as blueslip from "./blueslip";
import * as buddy_data from "./buddy_data"; import * as buddy_data from "./buddy_data";
@ -335,7 +335,7 @@ function render_user_card_popover(
$popover.addClass(get_popover_classname(template_class)); $popover.addClass(get_popover_classname(template_class));
$popover_title.append( $popover_title.append(
render_user_card_popover_title({ render_user_card_popover_avatar({
// See the load_medium_avatar comment for important background. // See the load_medium_avatar comment for important background.
user_avatar: people.small_avatar_url_for_person(user), user_avatar: people.small_avatar_url_for_person(user),
user_is_guest: user.is_guest, user_is_guest: user.is_guest,

0
web/templates/user_card_popover_title.hbs → web/templates/user_card_popover_avatar.hbs
View File