Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

typeahead: Refactor to avoid no-case-declarations issue.

This commit is contained in:
evykassirer 2024-03-01 14:39:42 -08:00 committed by Tim Abbott
parent e12543f957
commit 331efb0def
1 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
web/third/bootstrap-typeahead/typeahead.js
View File

@ -554,16 +554,6 @@ import {get_string_diff} from "../../src/util";
) {
return;
}
var hideOnEmpty = false;
// backspace
if (
e.keyCode === 8 &&
this.options.helpOnEmptyStrings && // Support for inputs to set the hideOnEmpty option explicitly to false
// to display typeahead after hitting backspace to clear the input.
(typeof this.options.hideOnEmpty === undefined || this.options.hideOnEmpty)
) {
hideOnEmpty = true;
}
if (this.options.openInputFieldOnKeyUp !== null && !this.shown) {
// If the typeahead isn't shown yet, the `lookup` call will open it.
// Here we make a callback to the input field before we open the
@ -571,7 +561,17 @@ import {get_string_diff} from "../../src/util";
// the search bar).
this.options.openInputFieldOnKeyUp();
}
this.lookup(hideOnEmpty);
// backspace
if (
e.keyCode === 8 &&
this.options.helpOnEmptyStrings && // Support for inputs to set the hideOnEmpty option explicitly to false
// to display typeahead after hitting backspace to clear the input.
(typeof this.options.hideOnEmpty === undefined || this.options.hideOnEmpty)
) {
this.lookup(true);
} else {
this.lookup(false);
}
}
this.maybeStopAdvance(e);