Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Add translation in the code review check list.

This commit is contained in:
hackerkid 2016-12-14 12:06:57 +05:30 committed by Tim Abbott
parent ee3fbe9193
commit 3236b8ee2b
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
docs/code-reviewing.md
View File

@ -59,6 +59,9 @@ participating in code review.
and unparameterized containser should be limited to cases where a
more precise type cannot be specified.
* *Translation.* Make sure that the strings are marked for
[translation].
* *Clear function, argument, variable, and test names.* Every new
piece of Zulip code will be read many times by other developers, and
future developers will grep for relevant terms when researching a