Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

eslint: Re-enable no-undef for TypeScript. 

@typescript-eslint/recommended disables no-undef on the theory that
TypeScript knows which globals are in scope.  However, some TypeScript
definitions include declarations for globals that may or may not
actually be available depending on the environment.  So we will need
to prohibit some globals that TypeScript knows about, and enforce that
they are properly imported.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg 2021-03-11 14:33:24 -08:00 committed by Tim Abbott
parent 1a2a3983ea
commit 31e865d9ed
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
.eslintrc.json
View File

@ -114,6 +114,15 @@
"location": false "location": false
} }
}, },
{
"files": ["frontend_tests/puppeteer_lib/**", "frontend_tests/puppeteer_tests/**"],
"globals": {
"$": false,
"current_msg_list": false,
"page_params": false,
"zulip_test": false
}
},
{ {
"files": ["static/js/**"], "files": ["static/js/**"],
"globals": { "globals": {
@ -161,7 +170,8 @@
"@typescript-eslint/prefer-regexp-exec": "error", "@typescript-eslint/prefer-regexp-exec": "error",
"@typescript-eslint/prefer-string-starts-ends-with": "error", "@typescript-eslint/prefer-string-starts-ends-with": "error",
"@typescript-eslint/promise-function-async": "error", "@typescript-eslint/promise-function-async": "error",
"@typescript-eslint/unified-signatures": "error" "@typescript-eslint/unified-signatures": "error",
"no-undef": "error"
} }
}, },
{ {